Fix error classification for array with null elements#25187
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jun 10, 2025
Merged
Fix error classification for array with null elements#25187rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
kewang1024
approved these changes
May 27, 2025
Collaborator
kewang1024
left a comment
There was a problem hiding this comment.
Can you also append the test result in the summary, thanks!
amitkdutta
approved these changes
May 29, 2025
Contributor
|
Since this is a user-facing change, please write a short release note in the PR description describing that this is now a user error |
rschlussel
approved these changes
Jun 6, 2025
Contributor
rschlussel
left a comment
There was a problem hiding this comment.
Just fix the format of the release notes entry so the CI passes. you can look at some other prs with release notes for examples on what it should look liek
Contributor
Author
|
@rschlussel Thank you. CI has passed. |
6 tasks
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presto does not support array comparison with null elements. Previously, it was classified as internal InvalidFunctionArgumentException. It is converted as a user error by using PrestoException.
Motivation and Context
This unsupported operation was misclassified, resulting in inaccuracies.
Impact
No impact.
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.