Add test coverage for SqlFunctionProperties equals#25002
Merged
duxiao1212 merged 1 commit intoprestodb:masterfrom Apr 30, 2025
Merged
Conversation
879fd21 to
d3e755a
Compare
rschlussel
previously approved these changes
Apr 29, 2025
presto-common/src/test/java/com/facebook/presto/common/function/TestSqlFunctionProperties.java
Outdated
Show resolved
Hide resolved
d3e755a to
c33b931
Compare
c33b931 to
85f2c3e
Compare
NikhilCollooru
approved these changes
Apr 30, 2025
21 tasks
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, in the PR #24614, we accidentally compared different fields in the SqlFunctionProperties, which caused an OOM error in the JVM metaspace and eventually led to a SEV. To prevent this issue from occurring again, we need to ensure that the SqlFunctionProperties equality function is implemented correctly. Additionally, we should create a unit test to reproduce the issue and prevent it from happening in the future.
Motivation and Context
Prevent incorrect implementation of the equals method in SqlFunctionProperties
Impact
low impact
Test Plan
N/A
Contributor checklist
Release Notes