Re-introduce improving the merging of operator stats#24921
Merged
shangm2 merged 1 commit intoprestodb:masterfrom Apr 16, 2025
Merged
Re-introduce improving the merging of operator stats#24921shangm2 merged 1 commit intoprestodb:masterfrom
shangm2 merged 1 commit intoprestodb:masterfrom
Conversation
shangm2
commented
Apr 16, 2025
|
|
||
| public List<OperatorStats> getOperatorSummaries() | ||
| { | ||
| return operatorStatsByKey.values().stream() |
NikhilCollooru
approved these changes
Apr 16, 2025
Collaborator
|
@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
AnuragKDwivedi
pushed a commit
to AnuragKDwivedi/presto-1
that referenced
this pull request
Apr 21, 2025
## Description 1. this pr re-introduce the prestodb#24414 , which cause a sev where written partition was not logged. The bug is a corner case, where while merging only one single non-mergeable operatorInfo, the old code will NOT perform any merge operation (since the add operation will only get invoke when the second operator stats shows up) and give back the operator info itself while prestodb#24414 will actually kick off a merge and gives null result. 2. This pr reintroduce prestodb#24414 and handles this corner case and also added specific unit tests for this scenario. ## Motivation and Context 1. re-introduce prestodb#24414 ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan 1. verifier runs log written partition correctly: <img width="1469" alt="Screenshot 2025-04-15 at 17 13 08" src="https://github.com/user-attachments/assets/f7c84a8f-7381-411a-95d1-15b075870b83" /> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == General Changes * Improve how we merge multiple operator stats together. * Improve metrics creation by refactoring local variables to a dedicated class. ```
13 tasks
21 tasks
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.