Skip to content

Java 17 and Jetty 12 upgrade #24866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZacBlanco merged 27 commits into from
Aug 13, 2025
Merged

Java 17 and Jetty 12 upgrade #24866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8273664
Upgrade airlift, jetty, and guice in root POM
ZacBlanco Mar 19, 2025
770d110
Move from javax to jakarta packages in pom files
ZacBlanco May 2, 2025
eb3f2e8
Move Java code from javax to jakarta
ZacBlanco May 2, 2025
36330fe
Migrate from com.facebook.drift to com.facebook.airlift.drift
ZacBlanco Apr 29, 2025
43dbdf4
Migrate from io.airlift:units to com.facebook.airlift:units
ZacBlanco Apr 24, 2025
c932864
Migrate from io.airlift:airline to com.facebook.airlift:airline
ZacBlanco Apr 22, 2025
1131192
Update all GH actions to java 17
ZacBlanco Apr 5, 2025
cdb7934
Disable modernizer plugin on each module
ZacBlanco Apr 9, 2025
6a167b2
Fix testValidation due to new error message
auden-woolfson Apr 14, 2025
cc3d3d3
Fix presto-on-spark tests
ZacBlanco Apr 15, 2025
731f16b
Add missing runtime dependencies for native tests
ZacBlanco Apr 17, 2025
a6495d5
Run tempto with Java 17
ZacBlanco Apr 22, 2025
303e95f
Fix URI compliance for Iceberg nested NS tests
ZacBlanco Apr 22, 2025
c467637
Force testng provider in surefire plugin
ZacBlanco Apr 9, 2025
ae638c6
Fix compilation for presto-testing-mysql with io.airlift.units
ZacBlanco Apr 24, 2025
ab07206
Fix ambiguous URIs in function server API
ZacBlanco Apr 24, 2025
e9061a9
Fix TestRangerBasedAccessControlConfig
ZacBlanco Apr 24, 2025
000b15a
Fix product tests
ZacBlanco Apr 24, 2025
02de7ff
Update documentation for Java 17 support
ZacBlanco Apr 29, 2025
0814d6b
Update docker image for JDK 17
ZacBlanco Apr 29, 2025
6c41e9a
Update jvm.config files for java 17
ZacBlanco Apr 29, 2025
eaf93ba
Update PrestoSystemRequirements for Java 17
ZacBlanco Apr 29, 2025
905ba51
Upgrade airbase and airlift
ZacBlanco Jul 10, 2025
5bb1ef7
Downgrade guice to 6.0.0
rschlussel Jul 1, 2025
61ae1cc
Fix build errors after downgrade
ZacBlanco Jul 10, 2025
025f231
[pos][native] Make pos native compatible with Java17 upgrade
shrinidhijoshi Jul 16, 2025
cdf7665
Upgrade to airlift 221, fix drift conflicts
ZacBlanco Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .github/workflows/arrow-flight-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
modules:
- ":presto-base-arrow-flight" # Only run tests for the `presto-base-arrow-flight` module

Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8.0.452
java-version: 17.0.15
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8.0.452
java-version: 17.0.15
cache: 'maven'
- name: Maven Install
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/hive-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kudu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maven-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
timeout-minutes: 45
concurrency:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/presto-release-prepare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
required: false

env:
JAVA_VERSION: ${{ vars.JAVA_VERSION || '17' }}
JAVA_VERSION: ${{ vars.JAVA_VERSION || '17.0.13' }}
JAVA_DISTRIBUTION: ${{ vars.JAVA_DISTRIBUTION || 'temurin' }}
MAVEN_OPTS: ${{ vars.MAVEN_OPTS }}
GIT_CI_USER: ${{ vars.GIT_CI_USER || 'prestodb-ci' }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/prestocpp-linux-build-and-unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8.0.452
java-version: 17.0.15
cache: 'maven'
- name: Download nodejs to maven cache
if: |
Expand Down Expand Up @@ -270,7 +270,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '8.0.452'
java-version: 17.0.15
cache: 'maven'
- name: Download nodejs to maven cache
if: |
Expand Down Expand Up @@ -358,7 +358,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '8.0.452'
java-version: 17.0.15
cache: 'maven'
- name: Download nodejs to maven cache
if: |
Expand Down Expand Up @@ -443,7 +443,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '8.0.452'
java-version: 17.0.15
cache: 'maven'
- name: Download nodejs to maven cache
if: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/product-tests-basic-environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/product-tests-specific-environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/singlestore-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 30
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/spark-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-other-modules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8.0.452, 17.0.15 ]
java: [ 17.0.15 ]
modules:
- ":presto-tests -P presto-tests-execution-memory"
- ":presto-tests -P presto-tests-general"
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ We recommend you use IntelliJ as your IDE. The code style template for the proje
.map(OriginalExpressionUtils::castToExpression)
```

* When appropriate use Java 8 Stream API
* When appropriate use Java Stream API
* Categorize errors when throwing an exception
* **Tests**
* Avoid adding `Thread.sleep` in tests--these can fail due to environmental conditions, such as garbage collection or noisy neighbors in the CI environment.
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ See [PrestoDB: Mission and Architecture](ARCHITECTURE.md).
## Requirements

* Mac OS X or Linux
* Java 8 Update 151 or higher (8u151+), 64-bit. Both Oracle JDK and OpenJDK are supported.
* Java 17 64-bit. Both Oracle JDK and OpenJDK are supported.
* Maven 3.6.3+ (for building)
* Python 2.4+ (for running with the launcher script)

Expand All @@ -38,8 +38,8 @@ After building Presto for the first time, you can load the project into your IDE
After opening the project in IntelliJ, double check that the Java SDK is properly configured for the project:

* Open the File menu and select Project Structure
* In the SDKs section, ensure that a 1.8 JDK is selected (create one if none exist)
* In the Project section, ensure the Project language level is set to 8.0 as Presto makes use of several Java 8 language features
* In the SDKs section, ensure that a distribution of JDK 17 is selected (create one if none exist)
* In the Project section, ensure the Project language level is set to at least 8.0.

Presto comes with sample configuration that should work out-of-the-box for development. Use the following options to create a run configuration:

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ARG JMX_PROMETHEUS_JAVAAGENT_VERSION=0.20.0
ENV PRESTO_HOME="/opt/presto-server"

RUN --mount=type=cache,target=/var/cache/dnf,sharing=locked \
dnf install -y java-11-openjdk less procps python3 \
dnf install -y java-17-openjdk less procps python3 \
&& ln -s $(which python3) /usr/bin/python \
# clean cache jobs
&& mv /etc/yum/protected.d/systemd.conf /etc/yum/protected.d/systemd.conf.bak
Expand Down
17 changes: 17 additions & 0 deletions docker/etc/jvm.config.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,20 @@
-XX:+HeapDumpOnOutOfMemoryError
-XX:+ExitOnOutOfMemoryError
-Djdk.attach.allowAttachSelf=true
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.ref=ALL-UNNAMED
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.security=ALL-UNNAMED
--add-opens=java.base/javax.security.auth=ALL-UNNAMED
--add-opens=java.base/javax.security.auth.login=ALL-UNNAMED
--add-opens=java.base/java.text=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
--add-opens=java.base/java.util.regex=ALL-UNNAMED
--add-opens=java.base/jdk.internal.loader=ALL-UNNAMED
--add-opens=java.base/sun.security.action=ALL-UNNAMED
--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED
Loading
Loading