[native] Allow options for wget and tar commands during setup Part:2 #24854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
auden-woolfson and
sh-shamsan
and removed request for
a team
czentgr
approved these changes
Apr 2, 2025
auden-woolfson
approved these changes
Apr 3, 2025
Contributor
auden-woolfson
left a comment
auden-woolfson
left a comment
There was a problem hiding this comment.
LGTM, please make sure checks are passing
Contributor
|
@anandamideShakyan Please rebase. |
majetideepak
approved these changes
May 12, 2025
anandamideShakyan
force-pushed
the
remove-tar-options
branch
from
5d56c6c to
4fd8c89
Compare
anandamideShakyan
force-pushed
the
remove-tar-options
branch
from
4fd8c89 to
49d16cb
Compare
6 tasks
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue:
The current setup scripts generate excessive output, the goal is to reduce the log output by implementing the following changes:
Avoid printing the files extracted by tar.
Silence the download progress from curl by using an appropriate curl option.
Suppress unnecessary CMake messages, logging only warnings instead of info or status messages.
Introduce a new environment variable to enable the extensive logging when needed.
These changes will help minimize log size while maintaining flexibility for detailed logging when required.
Motivation and Context
The current setup scripts generate excessive log output, which can overwhelm users and make it difficult to identify important information. This excessive logging increases log file sizes unnecessarily, which can be problematic for storage and debugging. By implementing changes to reduce log output, we aim to streamline the logging process, improve readability, and maintain flexibility for detailed logging when required.
This part addresses this comment from the reviewer since part 1 is already merged.