Skip to content

Pass full session to avoid Unknown connector errors #24803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaystarshot merged 1 commit into from
Apr 4, 2025
Merged

Pass full session to avoid Unknown connector errors #24803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ceberg/src/test/java/com/facebook/presto/iceberg/nessie/TestIcebergDistributedNessie.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,12 @@ public void testExpireSnapshotWithDeletedEntries()
.isInstanceOf(RuntimeException.class)
.hasMessageMatching("Cannot expire snapshots: GC is disabled .*");
}

@Test
public void testUnknownConnectorNotThrown()
{
// Checks an Unknown connector exception is not thrown when trying to explore through JDBC an Iceberg catalog of type Nessie
assertQuerySucceeds("select * from system.jdbc.schemas where TABLE_CATALOG = 'iceberg'");
assertQuerySucceeds("select * from system.jdbc.tables where TABLE_CAT = 'iceberg' and TABLE_SCHEM = 'tpch'");
}
}
4 changes: 2 additions & 2 deletions ...to-main-base/src/main/java/com/facebook/presto/connector/system/jdbc/SchemaJdbcTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package com.facebook.presto.connector.system.jdbc;

import com.facebook.presto.FullConnectorSession;
import com.facebook.presto.Session;
import com.facebook.presto.common.predicate.TupleDomain;
import com.facebook.presto.metadata.Metadata;
Expand All @@ -30,7 +31,6 @@
import java.util.Optional;

import static com.facebook.presto.common.type.VarcharType.createUnboundedVarcharType;
import static com.facebook.presto.connector.system.SystemConnectorSessionUtil.toSession;
import static com.facebook.presto.connector.system.jdbc.FilterUtil.filter;
import static com.facebook.presto.metadata.MetadataListing.listCatalogs;
import static com.facebook.presto.metadata.MetadataListing.listSchemas;
Expand Down Expand Up @@ -66,7 +66,7 @@ public ConnectorTableMetadata getTableMetadata()
@Override
public RecordCursor cursor(ConnectorTransactionHandle transactionHandle, ConnectorSession connectorSession, TupleDomain<Integer> constraint)
{
Session session = toSession(transactionHandle, connectorSession);
Session session = ((FullConnectorSession) connectorSession).getSession();
Optional<String> catalogFilter = FilterUtil.stringFilter(constraint, 1);

Builder table = InMemoryRecordSet.builder(METADATA);
Expand Down
4 changes: 2 additions & 2 deletions presto-main-base/src/main/java/com/facebook/presto/connector/system/jdbc/TableJdbcTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package com.facebook.presto.connector.system.jdbc;

import com.facebook.presto.FullConnectorSession;
import com.facebook.presto.Session;
import com.facebook.presto.common.predicate.TupleDomain;
import com.facebook.presto.metadata.Metadata;
Expand All @@ -33,7 +34,6 @@
import java.util.Set;

import static com.facebook.presto.common.type.VarcharType.createUnboundedVarcharType;
import static com.facebook.presto.connector.system.SystemConnectorSessionUtil.toSession;
import static com.facebook.presto.connector.system.jdbc.FilterUtil.filter;
import static com.facebook.presto.connector.system.jdbc.FilterUtil.stringFilter;
import static com.facebook.presto.connector.system.jdbc.FilterUtil.tablePrefix;
Expand Down Expand Up @@ -80,7 +80,7 @@ public ConnectorTableMetadata getTableMetadata()
@Override
public RecordCursor cursor(ConnectorTransactionHandle transactionHandle, ConnectorSession connectorSession, TupleDomain<Integer> constraint)
{
Session session = toSession(transactionHandle, connectorSession);
Session session = ((FullConnectorSession) connectorSession).getSession();
Optional<String> catalogFilter = stringFilter(constraint, 0);
Optional<String> schemaFilter = stringFilter(constraint, 1);
Optional<String> tableFilter = stringFilter(constraint, 2);
Expand Down
Loading