Add ConnectorMetadata.commitPageSinkAsync hook for ConnectorDeleteTableHandle #24783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghelmling
requested review from
a team,
feilong-liu,
jaystarshot and
vivek-bharathan
as code owners
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71692192 |
…leHandle (prestodb#24783) Summary: When ConnectorDeleteTableHandle and DeleteTableHandle were added to the ConnectorMetadata interface for beginDelete() / finishDelete(), we missed adding a commitPageSinkAsync() for implementations which use a PageSink to write out deletes. This corrects the oversight and puts a hook in place for implementors that need it. Differential Revision: D71692192
ghelmling
force-pushed
the
export-D71692192
branch
from
a879e95 to
6c67c71
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71692192 |
rschlussel
approved these changes
Mar 26, 2025
30 tasks
pradeepvaka
pushed a commit
to pradeepvaka/presto
that referenced
this pull request
Apr 11, 2025
…leHandle (prestodb#24783) Summary: When ConnectorDeleteTableHandle and DeleteTableHandle were added to the ConnectorMetadata interface for beginDelete() / finishDelete(), we missed adding a commitPageSinkAsync() for implementations which use a PageSink to write out deletes. This corrects the oversight and puts a hook in place for implementors that need it. Differential Revision: D71692192
30 tasks
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When ConnectorDeleteTableHandle and DeleteTableHandle were added to the ConnectorMetadata interface for beginDelete() / finishDelete(), we missed adding a commitPageSinkAsync() for implementations which use a PageSink to write out deletes. This corrects the oversight and puts a hook in place for implementors that need it.
Differential Revision: D71692192