Skip to content

Conversation

@zation99
Copy link
Contributor

Description

Materialized view refresh was not working due to the related plan handle is not mapped to CPP. It causes failure:
RefreshMaterializedViewHandle no abstract type ExecutionWriterTarget

This PR adds the mapping to the cpp protocol.

Motivation and Context

Impact

Test Plan

Run refresh materialized view succeeded in cpp.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@zation99 zation99 requested a review from a team as a code owner March 22, 2025 16:36
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Mar 22, 2025
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zation99

@zation99 zation99 merged commit 1332125 into prestodb:master Mar 23, 2025
98 checks passed
@facebook-github-bot
Copy link
Collaborator

@zation99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
pradeepvaka pushed a commit to pradeepvaka/presto that referenced this pull request Apr 11, 2025
Add MV refresh handler mapping to cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants