Skip to content

Make OutputBuffers Thrift-compatible#24701

Merged
shangm2 merged 1 commit intoprestodb:masterfrom
shangm2:thrift_migration_outputBuffers
Mar 12, 2025
Merged

Make OutputBuffers Thrift-compatible#24701
shangm2 merged 1 commit intoprestodb:masterfrom
shangm2:thrift_migration_outputBuffers

Conversation

@shangm2
Copy link
Contributor

@shangm2 shangm2 commented Mar 10, 2025

Description

  1. We are doing thrift migration for TaskUpdateRequest
  2. OutputBuffers is one of the fields in TaskUpdateRequest

Motivation and Context

  1. Use thrift for TaskUpdateRequest to make the communication between coordinator and worker fast

Impact

Test Plan

  1. running verifier test

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@shangm2 shangm2 requested a review from a team as a code owner March 10, 2025 21:45
@shangm2 shangm2 requested a review from presto-oss March 10, 2025 21:45
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Mar 10, 2025
Copy link
Contributor

@NikhilCollooru NikhilCollooru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes for this is not required as there is no change in behavior

@shangm2 shangm2 merged commit 3f99d9c into prestodb:master Mar 12, 2025
92 checks passed
unidevel pushed a commit to unix280/presto that referenced this pull request Mar 12, 2025
@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
pradeepvaka pushed a commit to pradeepvaka/presto that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants