Skip to content

Upgrade build to be compatible with JDK17 #24677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschlussel merged 2 commits into from
Mar 7, 2025
Merged

Upgrade build to be compatible with JDK17 #24677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d99256b
Upgrade Kafka version to 3.9.0
aaneja Mar 5, 2025
3ec5531
Add JDK 17 build support
aaneja Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions .github/workflows/cleanup.yml
View file
Open in desktop

This file was deleted.

16 changes: 12 additions & 4 deletions .github/workflows/hive-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,16 @@ jobs:
- '!presto-docs/**'

hive-tests:
strategy:
fail-fast: false
Copy link
Contributor

@czentgr czentgr Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to force the build for the other java version if one of them fails?

Copy link
Contributor

@ZacBlanco ZacBlanco Mar 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short offline discussion: we disabled fail-fast initially during our testing so that we could view all the errors for both 8 & 17 builds. This shouldn't be required any more though. Will create a follow-up PR to remove fail-fast (the default is true)

matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -45,7 +49,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down Expand Up @@ -75,12 +79,16 @@ jobs:
fi

hive-dockerized-tests:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 20
concurrency:
group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -89,7 +97,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/kudu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ jobs:
codechange:
- '!presto-docs/**'
kudu:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -43,7 +47,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/maven-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ env:

jobs:
maven-checks:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
timeout-minutes: 45
concurrency:
group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -29,7 +33,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/product-tests-basic-environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ jobs:
codechange:
- '!presto-docs/**'
product-tests-basic-environment:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-product-tests-basic-environment-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-product-tests-basic-environment-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -49,7 +53,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand All @@ -58,4 +62,6 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
- name: Run Product Tests Basic Environment
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh multinode -x quarantine,big_query,storage_formats,profile_specific_tests,tpcds,cassandra,mysql_connector,postgresql_connector,mysql,kafka,avro
40 changes: 36 additions & 4 deletions .github/workflows/product-tests-specific-environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ jobs:
codechange:
- '!presto-docs/**'
product-tests-specific-environment1:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-product-tests-specific-environment1-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-product-tests-specific-environment1-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -49,7 +53,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand All @@ -58,26 +62,40 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
- name: Product Tests Specific 1.1
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode -g hdfs_no_impersonation,avro
- name: Product Tests Specific 1.2
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-no-impersonation -g hdfs_no_impersonation
# temporarily disable this flaky run. see issue #20388 for details
# - name: Product Tests Specific 1.3
# run: presto-product-tests/bin/run_on_docker.sh singlenode-hdfs-impersonation -g storage_formats,cli,hdfs_impersonation
- name: Product Tests Specific 1.4
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-impersonation -g storage_formats,cli,hdfs_impersonation,authorization,hive_file_header
- name: Product Tests Specific 1.5
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-impersonation-cross-realm -g storage_formats,cli,hdfs_impersonation
- name: Product Tests Specific 1.6
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh multinode-tls-kerberos -g cli,group-by,join,tls

product-tests-specific-environment2:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-product-tests-specific-environment2-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-product-tests-specific-environment2-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -92,7 +110,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand All @@ -101,19 +119,33 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
- name: Product Tests Specific 2.1
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-ldap -g ldap -x simba_jdbc
- name: Product Tests Specific 2.2
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh multinode-tls -g smoke,cli,group-by,join,tls
- name: Product Tests Specific 2.3
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-mysql -g mysql_connector,mysql
- name: Product Tests Specific 2.4
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-postgresql -g postgresql_connector
- name: Product Tests Specific 2.5
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-cassandra -g cassandra
# temporarily disable this flaky run. see issue #20388 for details
# - name: Product Tests Specific 2.6
# run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-impersonation-with-wire-encryption -g storage_formats,cli,hdfs_impersonation,authorization
- name: Product Tests Specific 2.7
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-kafka -g kafka
- name: Product Tests Specific 2.8
env:
OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
run: presto-product-tests/bin/run_on_docker.sh singlenode-sqlserver -g sqlserver
8 changes: 6 additions & 2 deletions .github/workflows/singlestore-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,17 @@ jobs:
codechange:
- '!presto-docs/**'
singlestore-dockerized-tests:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'

timeout-minutes: 30
concurrency:
group: ${{ github.workflow }}-singlestore-dockerized-tests-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-singlestore-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -56,7 +60,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/spark-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@ jobs:
codechange:
- '!presto-docs/**'
spark-integration:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-spark-integration-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-spark-integration-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -44,7 +48,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/test-other-modules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@ jobs:
codechange:
- '!presto-docs/**'
test-other-modules:
strategy:
fail-fast: false
matrix:
java: [ 8, 17.0.13 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-test-other-modules-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-test-other-modules-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -44,7 +48,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
cache: 'maven'
- name: Download nodejs to maven cache
run: .github/bin/download_nodejs
Expand Down
Loading
Loading