Skip to content

Access TypeManager and FunctionMetadataManager functionalities from FunctionAndTypeResolver instead of FunctionAndTypeManager#24640

Open
pdabre12 wants to merge 1 commit intoprestodb:masterfrom
pdabre12:refactor-type-manager-methods
Open

Access TypeManager and FunctionMetadataManager functionalities from FunctionAndTypeResolver instead of FunctionAndTypeManager#24640
pdabre12 wants to merge 1 commit intoprestodb:masterfrom
pdabre12:refactor-type-manager-methods

Conversation

@pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Feb 27, 2025

Description

This change removes methods from FunctionAndTypeManager that are already accessible via FunctionAndTypeResolver.
These methods are now intended to be used exclusively through FunctionAndTypeResolver.

Motivation and Context

Functionalities relying on TypeManager and FunctionMetadataManager interfaces should rely on FunctionAndTypeResolver instead of FunctionAndTypeManager.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 27, 2025
@pdabre12 pdabre12 requested a review from presto-oss February 27, 2025 02:29
@prestodb-ci prestodb-ci requested review from a team, namya28 and sh-shamsan and removed request for a team February 27, 2025 02:29
@pdabre12 pdabre12 changed the title Refactor type manager methods [WIP] Refactor type manager methods Feb 27, 2025
@pdabre12 pdabre12 marked this pull request as draft February 27, 2025 02:30
@pdabre12 pdabre12 mentioned this pull request Feb 27, 2025
6 tasks
@pdabre12 pdabre12 force-pushed the refactor-type-manager-methods branch from 5aa66b7 to 7afa905 Compare March 3, 2025 20:51
@pdabre12 pdabre12 force-pushed the refactor-type-manager-methods branch from 7afa905 to 4ea79ae Compare March 12, 2025 18:49
@pdabre12 pdabre12 force-pushed the refactor-type-manager-methods branch from 4ea79ae to 0ad3846 Compare March 27, 2025 21:18
@pdabre12 pdabre12 changed the title [WIP] Refactor type manager methods Access functionalities from FunctionAndTypeResolver instead of FunctionAndTypeManager Apr 7, 2025
@pdabre12 pdabre12 changed the title Access functionalities from FunctionAndTypeResolver instead of FunctionAndTypeManager Access TypeManager and FunctionMetadataManager functionalities from FunctionAndTypeResolver instead of FunctionAndTypeManager Apr 7, 2025
@pdabre12 pdabre12 marked this pull request as ready for review April 7, 2025 18:20
@pdabre12 pdabre12 requested a review from a team as a code owner April 7, 2025 18:20
@prestodb-ci prestodb-ci requested a review from a team April 7, 2025 18:20
@pdabre12
Copy link
Contributor Author

pdabre12 commented Apr 7, 2025

@rschlussel
What do you think of this refactor?
Meant to address this comment: #24179 (comment)

@pdabre12 pdabre12 removed the request for review from a team April 7, 2025 18:21
@pdabre12 pdabre12 requested a review from rschlussel April 7, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants