[native] Fix includes #24625
Merged
[native] Fix includes #24625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
majetideepak
requested changes
Feb 25, 2025
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
The commit needs the [native] prefix.
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 25, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
438732a to
39ef4d1
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 25, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
39ef4d1 to
2325c23
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
swapsmagic
approved these changes
Feb 25, 2025
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
2325c23 to
fa7fa18
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
fa7fa18 to
0cc9224
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
0cc9224 to
986bbd9
Compare
Contributor
|
Saved that user @joeg is from Meta |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
986bbd9 to
0d95cc3
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
majetideepak
approved these changes
Feb 27, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
joeg
force-pushed
the
export-D70195333
branch
from
0d95cc3 to
d5d46ba
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
This was referenced Mar 10, 2025
jp-sivaprasad
pushed a commit
to jp-sivaprasad/presto
that referenced
this pull request
Mar 10, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
30 tasks
pradeepvaka
pushed a commit
to pradeepvaka/presto
that referenced
this pull request
Apr 11, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
30 tasks
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it
Reviewed By: karteekmurthys
Differential Revision: D70195333