[docs] Add documentation for cache configuration properties#24623
Merged
steveburnett merged 1 commit intoprestodb:masterfrom Mar 3, 2025
Merged
[docs] Add documentation for cache configuration properties#24623steveburnett merged 1 commit intoprestodb:masterfrom
steveburnett merged 1 commit intoprestodb:masterfrom
Conversation
2427fdf to
3d22475
Compare
steveburnett
requested changes
Feb 25, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Some formatting issues and some nits of phrasing suggestions. Looks good overall!
6 tasks
3d22475 to
d835fe3
Compare
czentgr
reviewed
Mar 1, 2025
steveburnett
requested changes
Mar 3, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc update, this looks much better! A few nits of formatting,
569293a to
45286ac
Compare
steveburnett
requested changes
Mar 3, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the update! One final nit.
45286ac to
6bdc3ae
Compare
steveburnett
approved these changes
Mar 3, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
This was referenced Mar 10, 2025
30 tasks
30 tasks
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for cache configuration properties
All of these cache configuration properties are defined here in the codebase:
https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/main/common/Configs.h#L328
Relates to facebookincubator/velox#11429
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.