Add checkQueryIntegrity call to DispatchManager#24574
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Feb 21, 2025
Merged
Add checkQueryIntegrity call to DispatchManager#24574rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
kevintang2022
requested review from
a team,
agrawalreetika,
elharo,
feilong-liu,
jaystarshot and
vivek-bharathan
as code owners
kevintang2022
changed the title
Contributor
|
LGTM. Thanks for spotting the issue and fixing it. Maybe add a verifier run for testing. |
shangm2
previously approved these changes
Feb 19, 2025
kevintang2022
force-pushed
the
add-check-query-integrity-call-to-dispatch
branch
from
04496cc to
88852b6
Compare
rschlussel
reviewed
Feb 19, 2025
presto-spi/src/main/java/com/facebook/presto/spi/security/AccessControlContext.java
Outdated
Show resolved
Hide resolved
kevintang2022
force-pushed
the
add-check-query-integrity-call-to-dispatch
branch
2 times, most recently
from
8192ec6 to
5a0b323
Compare
rschlussel
reviewed
Feb 19, 2025
presto-spi/src/main/java/com/facebook/presto/spi/security/AccessControlContext.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I ran a verifier test: https://our.internmc.facebook.com/intern/presto/verifier/results/?test_id=211218 |
…AccessControlContext Add call to check query integrity Checkstyle Fix constrcutor usage Fix usages of constructor Whitespace Add test coverage for access control context Rename to schema from sqlnamespace Fix catalog name
kevintang2022
force-pushed
the
add-check-query-integrity-call-to-dispatch
branch
from
d85651d to
87fb774
Compare
rschlussel
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Github issue: https://github.com/orgs/prestodb/discussions/24526
Impact
Test Plan
Add tests to TestQueryManager.java to check for inclusion of catalog and sqlNamespace fields in AccessControlContext.
Contributor checklist
Deployed change to a test cluster and ran verifier tests: https://our.internmc.facebook.com/intern/presto/verifier/results/?test_id=211218
Release Notes
Please follow release notes guidelines and fill in the release notes below.