Skip to content

ArrowFlight module - do not bind class to itself#24540

Merged
BryanCutler merged 1 commit intoprestodb:masterfrom
elbinpallimalilibm:arrow_flight_module_binding
Feb 12, 2025
Merged

ArrowFlight module - do not bind class to itself#24540
BryanCutler merged 1 commit intoprestodb:masterfrom
elbinpallimalilibm:arrow_flight_module_binding

Conversation

@elbinpallimalilibm
Copy link
Contributor

Description

Do not bind ArrowBlockBuilder to itself.

Motivation and Context

If a connector extending presto-base-arrow-flight does not customise ArrowBlockBuilder and bind the customisation in the connector's module, a runtime error will be thrown because ArrowBlockBuilder is being bound to itself.

Impact

No error will be thrown if a concrete implementation of presto-base-arrow-flight does not extend ArrowBlockBuilder.

Test Plan

Tested this change by implementing a concrete connector that doesn't customise ArrowBlockBuilder.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@elbinpallimalilibm elbinpallimalilibm requested a review from a team as a code owner February 12, 2025 16:39
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 12, 2025
@prestodb-ci prestodb-ci requested review from a team, BryanCutler and bibith4 and removed request for a team February 12, 2025 16:39
Copy link
Contributor

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can reproduce the problem and checked that this didn't affect being able to override the ArrowBlockBuilder.

@BryanCutler BryanCutler merged commit 0370282 into prestodb:master Feb 12, 2025
54 checks passed
jp-sivaprasad pushed a commit to jp-sivaprasad/presto that referenced this pull request Mar 10, 2025
If a connector extending presto-base-arrow-flight does not customise ArrowBlockBuilder and bind the customisation in the connector's module, a runtime error will be thrown because ArrowBlockBuilder is being bound to itself.
@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
pradeepvaka pushed a commit to pradeepvaka/presto that referenced this pull request Apr 11, 2025
If a connector extending presto-base-arrow-flight does not customise ArrowBlockBuilder and bind the customisation in the connector's module, a runtime error will be thrown because ArrowBlockBuilder is being bound to itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants