ArrowFlight module - do not bind class to itself#24540
Merged
BryanCutler merged 1 commit intoprestodb:masterfrom Feb 12, 2025
Merged
ArrowFlight module - do not bind class to itself#24540BryanCutler merged 1 commit intoprestodb:masterfrom
BryanCutler merged 1 commit intoprestodb:masterfrom
Conversation
BryanCutler
approved these changes
Feb 12, 2025
Contributor
BryanCutler
left a comment
There was a problem hiding this comment.
LGTM. I can reproduce the problem and checked that this didn't affect being able to override the ArrowBlockBuilder.
jaystarshot
approved these changes
Feb 12, 2025
This was referenced Mar 10, 2025
jp-sivaprasad
pushed a commit
to jp-sivaprasad/presto
that referenced
this pull request
Mar 10, 2025
If a connector extending presto-base-arrow-flight does not customise ArrowBlockBuilder and bind the customisation in the connector's module, a runtime error will be thrown because ArrowBlockBuilder is being bound to itself.
30 tasks
pradeepvaka
pushed a commit
to pradeepvaka/presto
that referenced
this pull request
Apr 11, 2025
If a connector extending presto-base-arrow-flight does not customise ArrowBlockBuilder and bind the customisation in the connector's module, a runtime error will be thrown because ArrowBlockBuilder is being bound to itself.
30 tasks
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not bind ArrowBlockBuilder to itself.
Motivation and Context
If a connector extending presto-base-arrow-flight does not customise ArrowBlockBuilder and bind the customisation in the connector's module, a runtime error will be thrown because ArrowBlockBuilder is being bound to itself.
Impact
No error will be thrown if a concrete implementation of presto-base-arrow-flight does not extend ArrowBlockBuilder.
Test Plan
Tested this change by implementing a concrete connector that doesn't customise ArrowBlockBuilder.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.