add mysql compatible function bit_length#24531
Conversation
|
|
375c8bc to
3ae5a92
Compare
|
Thanks for the release note! A few minor changes suggested to follow the Release Notes Guidelines. |
|
Can you please add some documentation? (preferrably in https://prestodb.io/docs/current/functions/string.html) |
d75c251 to
4a7156e
Compare
Done. |
Done. |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, new local doc build, looks good. Thanks!
|
|
||
| @Description("count of bits for the given string") | ||
| @ScalarFunction("bit_length") | ||
| @LiteralParameters("x") |
There was a problem hiding this comment.
This literal parameter is not needed?
There was a problem hiding this comment.
Here I refer to the implementation of the length function in StringFunctions.java.
|
I think you can squash both commits into the first one |
4a7156e to
4de2500
Compare
Done. |
Description
Add a mysql compatible function bit_length, it returns the count of bits for the given string.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.