[native] Add Apache Arrow Flight Connector #24504

BryanCutler · 2025-02-05T21:47:30Z

Description

Add Prestissimo support for Apache Arrow Flight connectors.

The native Arrow Flight connector can be used to connect to any Arrow Flight enabled Data Source. The metadata layer is handled by the Presto coordinator and does not need to be re-implemented in C++. Any Java connector that inherits from presto-base-arrow-flight can use this connector as it's counterpart for the Prestissimo layer.

Different Arrow-Flight enabled data sources can differ in authentication styles. A plugin-style interface is provided to handle such cases with custom authentication code by extending arrow_flight::auth::Authenticator.

Motivation and Context

RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0004-arrow-flight-connector.md#prestissimo-implementation

Continues from #24082

Impact

Arrow Flight based connector will be supported in Prestissimo.

Test Plan

Unit Tests set up a testing Arrow Flight server and exchange data using the new connector.

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

== RELEASE NOTES ==

Prestissimo (Native Execution)
* Add support for Apache Arrow Flight connectors

steveburnett · 2025-02-05T21:49:31Z

Thanks for the release note!

New release note guidelines. Please remove the manual PR link in the following format from the release note entries for this PR.


:pr:`**`

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

BryanCutler · 2025-02-05T21:52:53Z

Great work from @Rijin-N in #24082. I didn't make any major changes, just updated the protocol to what was merged in Java from #24427, fixed some build issues, added tests for custom authentication and some minor tweaks. I'll try to highlight my changes below.

steveburnett

Thanks for the doc! One nit of formatting.

steveburnett · 2025-02-05T21:53:08Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/data/README.md

+The `tls_certs` directory contains placeholder TLS certificates generated for unit testing the Arrow Flight Connector with TLS enabled. These certificates are not intended for production use and should only be used in the context of unit tests.
+
+### Generating TLS Certificates
+To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:


Suggested change

To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:

To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:

Add a line after this blank line to separate this text and the command. Without the line, it looks like this:

BryanCutler · 2025-02-05T21:56:01Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowFlightConnector.cpp

+  }
+}
+
+void FlightDataSource::addSplit(std::shared_ptr<ConnectorSplit> split) {


Did some minor cleanup in this method to simply use of the serialized FlightEndpoint

BryanCutler · 2025-02-05T22:00:19Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/CMakeLists.txt

+# limitations under the License.
+find_package(Arrow REQUIRED)
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(ARROW_FLIGHT REQUIRED IMPORTED_TARGET GLOBAL arrow-flight)


I needed to add GLOBAL for using PkgConfig to prevent an -larrow-flight linker error. This seems like a better general solution to reference the libraries, see https://stackoverflow.com/questions/29191855/what-is-the-proper-way-to-use-pkg-config-from-cmake for more details

Why choose PkgConfig approach and not how Velox finds Arrow? We should use one approach for consistency.

@Rijin-N had it building with PkgConfig, and one of the first things I tried was changing this to the standard approach. I could not get it to find the flight libraries in my environment though. The only way I could get it to work was to revert back to PkgConfig and add GLOBAL.

@Rijin-N do you remember why PkgConfig was used?

@BryanCutler I also tried to use the velox way of finding arrow-flight libraries. But it did not work. Thats why we decided to use PkgConfig

@majetideepak I went back and tried this again, using find_package like this in arrow_flight/CMakeLists.txt

find_package(Arrow REQUIRED) find_package(ArrowFlight REQUIRED)

I get this CMake error:

CMake Error at ../working/deps-install/lib64/cmake/ArrowFlight/ArrowFlightConfig.cmake:64 (arrow_keep_backward_compatibility): Unknown CMake command "arrow_keep_backward_compatibility". Call Stack (most recent call first): presto_cpp/main/connectors/arrow_flight/CMakeLists.txt:13 (find_package)

This errors on the line to find_package(ArrowFlight Required) but arrow_keep_backward_compatibility is defined in ArrowConfig.cmake and I'm not sure why it can't find it, but this isn't a problem when using PkgConfig.

Ok, I tried changing the Arrow package to find_package(Arrow REQUIRED CONFIG) and seems to work with that, so I'll update

BryanCutler · 2025-02-05T22:01:06Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/FlightConfig.cpp

+  return config_->get<bool>(kServerVerify, true);
+}
+
+std::optional<std::string> FlightConfig::serverSslCertificate() {


This was folly::Optional, changed to be consistent

BryanCutler · 2025-02-05T22:03:02Z

...ive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorAuthTest.cpp

@@ -0,0 +1,251 @@
+/*


Added these tests to verify adding a custom authenticator works

BryanCutler · 2025-02-05T22:04:16Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/CMakeLists.txt

+
+target_link_libraries(
+  presto_flight_connector_infra_test presto_protocol
+  presto_flight_connector_test_lib GTest::gtest GTest::gtest_main ${GLOG})


Added G stuff due to linker error

BryanCutler · 2025-02-05T22:06:01Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/utils/FlightConnectorTestBase.h

+  virtual arrow::flight::Location getServerLocation();
+
+  virtual void setFlightServerOptions(
+      arrow::flight::FlightServerOptions* serverOptions) {}


Server options now specified by subclasses

steveburnett

LGTM! (docs)

BryanCutler · 2025-02-05T23:01:24Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/auth/Authenticator.cpp

+#include "velox/common/base/Exceptions.h"
+
+namespace facebook::presto::connector::arrow_flight::auth {
+namespace {


changed this to be in an anonymous namespace, instead of static

BryanCutler · 2025-02-05T23:05:18Z

presto-native-execution/presto_cpp/main/SystemConnector.cpp

    const protocol::ConnectorSplit* const connectorSplit,
-    const protocol::SplitContext* splitContext) const {
+    const protocol::SplitContext* splitContext,
+    const std::map<std::string, std::string>& extraCredentials) const {


@Rijin-N @elbinpallimalilibm is there a specific requirement to use these extraCredentials to authenticate a Flight client? I would think most users would prefer to authenticate the client with a token in the header, rather than use this. The Java Arrow Connector does not have this either.

@BryanCutler the base Presto (Java) Flight Connector is a template and not a full connector, and elects not to do authentication at all. The idea is that the authentication mechanism is largely dependent on the specific Flight server, so the whole business of authentication should be dealt with by the specialized connectors.

The problem we need to solve is that different Presto users may have different sets of access permissions on the connected Arrow Flight server. In this case we need to "pass through" the Presto user's authentication to the connected Flight Server, which means we somehow need to send the credentials from the Presto coordinator to the Presto workers.

In Java, there is an Identity API which we can use through connectorSession.getIdentity().getExtraCredentials().
IBM's specialization of the base Flight connector uses this API to pass the user's token to the workers. This isn't possible in Prestissimo because Velox connectors have no concept of Identity at all, so we need to pass the token in the split.

This issue provides more context:
#22849

There's also a corresponding Velox issue:
facebookincubator/velox#10107

Thanks for the background @ashkrisk . This related issues you linked are proposing adding an Identity data structure that all prestissimo connectors can access, but it is so far unresolved. I think this is a better solution that simply passing through a map, so we should hold off of adding these extraCredentials until we can get the right API with an Identity. WDYT?
cc @majetideepak @aditi-pandit

@BryanCutler we need this to get the multi-user setup working (IBM's flavor of the Flight connector relies on it). You can leave this off for now as long as you're able to maintain the diff in IBM code until there's a better solution in OSS.

@ashkrisk we need to make sure we have a discussion and proper design before adding APIs like this, since this also affects other connectors. I believe it was mentioned there could be a security concern if the credentials are added to the split, which is then serialized.

@BryanCutler do we need to get a meeting to talk about this?

I discussed with @majetideepak and @aditi-pandit , and have a possible way forward that I'm looking into, and I'll report back

@BryanCutler With regards to security, any method used to transfer the credentials from the coordinator to the worker requires serialization at some point. This includes the Identity framework available in Java. To ensure security, you need to ensure encrypted connections between all Presto nodes.

Obviously, it's better to have dedicated infra for this, so hopefully you can get together and work something out.

The plan is to incorporate #22859 which will add the extraCredentials to the connector session properties. This will be available to the Flight data source when it is processing the split and can use them for authentication. I'll try to add a test for this if I'm able to.

BryanCutler · 2025-02-06T22:59:07Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/FlightConfig.cpp

+}
+
+bool FlightConfig::serverVerify() {
+  return config_->get<bool>(kServerVerify, false);


Changed default to "false" to be consistent with Java

We probably want the default to be true for both Java and C++, otherwise by default there's no protection against server impersonation. Having this off is good for testing, but in production it's much better to leave it on unless there's a VERY good reason not to.

server verify is by default true in Java

Good point, the default behavior for the Flight client is to raise an error if using TLS and a certificate is provided but verify is disabled, and you need to explicitly disable it when using TLS.

I didn't catch that the Java connector defaults the config to NULL, which translates to true. I think that's confusing and we should not make it nullable. I'll change Java and here to default to true.

updated the Java side in #24518 and changed the default here too

aditi-pandit

Thanks @BryanCutler. Did a quick round of the code.

aditi-pandit · 2025-02-12T03:25:04Z

presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml

  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTableLayoutHandle.java
  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTransactionHandle.java
  - presto-spi/src/main/java/com/facebook/presto/spi/function/AggregationFunctionMetadata.java
-  - presto-function-namespace-managers-common/src/main/java/com/facebook/presto/functionNamespace/JsonBasedUdfFunctionMetadata.java


Why did JsonBasedUdfFunctionMetadata get dropped ?

must have been my mistake, I'll put it back

presto-native-execution/presto_cpp/main/connectors/CMakeLists.txt

aditi-pandit · 2025-02-12T04:04:42Z

presto-native-execution/presto_cpp/main/connectors/ConnectorRegistration.cpp

+
+namespace facebook::presto::connector {
+
+void registerAllPrestoConnectors() {


Nit : Rename registerOptionalConnectors ?

registerConnectors will do as well.
We should also move the existing connector registrations here.

We can do away with the connector namespace since the function name has Connectors.

The file names can also be Registration.h/.cpp since they are in the connectors folder.
presto-native-execution/presto_cpp/main/connectors/Registration.h

Let's move the SystemConnector here as well.

ok sounds good

Let's move the SystemConnector here as well.

@majetideepak should the SystemConnector be under namespace facebook::presto::connector like ArrowFlightConnector?

Could you clarify if you mean the source files SystemConnector.cpp/h or just the registration?

edit: confirmed moving sources for connectors also

presto-native-execution/presto_cpp/main/connectors/arrow_flight/Macros.h

aditi-pandit · 2025-02-12T06:18:50Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowPrestoToVeloxConnector.cpp

+std::unique_ptr<velox::connector::ColumnHandle>
+ArrowPrestoToVeloxConnector::toVeloxColumnHandle(
+    const protocol::ColumnHandle* column,
+    const TypeParser& typeParser) const {


Wrap unused parameters in comments... /typeParser/

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTlsTest.cpp

aditi-pandit · 2025-02-12T06:56:50Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/TestFlightServerTest.cpp

+
+std::unique_ptr<TestFlightServer> TestFlightServerTest::server;
+
+TEST_F(TestFlightServerTest, basicTest) {


Don't understand the purpose of this test. It doesn't seem to be related to the Connector.

I'm not too sure either, it's part of presto_flight_connector_infra_test tests, which is separate. It starts a server, adds data, then makes it's own client to get the flight stream - not using the connector. So it seems to be testing that the test server can serve Flight clients correctly, but that is also covered with the regular connector tests. @Rijin-N could you comment on this test?

The goal here is to run a simple test to be confident that the Test Flight Server is working correctly. Now, any failures that happen in the actual connector tests can be safely assumed to be a problem with the connector and not with the server, potentially making things easier to debug.

This is like the difference between testing each component vs having only integration tests.

aditi-pandit · 2025-02-12T07:09:36Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTlsTest.cpp

+                {1, 12, 2, std::numeric_limits<int64_t>::max()})}));
+
+    auto idVec = makeFlatVector<int64_t>(
+        {1, 12, 2, std::numeric_limits<int64_t>::max()});


Abstract a variable for {1, 12, 2, std::numeric_limits<int64_t>::max()} so that it can be used in the input and result vector.

aditi-pandit · 2025-02-12T07:12:51Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTlsTest.cpp

+
+namespace {
+
+namespace velox = facebook::velox;


Haven't seen this style of shorthand for namespaces in Prestissimo code. Can these be removed ?

aditi-pandit · 2025-02-12T07:16:42Z

...-native-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTest.cpp

+      "missing columnHandle for column 'value'");
+}
+
+TEST_F(FlightConnectorTest, dataSourceTest) {


test names shouldn't have the word "Test" in them. Please fix the names.

BryanCutler · 2025-03-14T03:06:01Z

Rebased and added additional tests for multiple batches and splits

aditi-pandit

@BryanCutler : The code is looking good. I have few minor comments. But overall I'm satisfied with the code. Will give an approval once Deepak approves all the build related changes.

aditi-pandit · 2025-03-19T06:15:57Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/utils/Utils.h

+namespace facebook::presto::test {
+
+template <typename T>
+std::shared_ptr<arrow::Array> makeNumericArray(


Nit : Add an alias for std::shared_ptrarrow::Array to reuse

using ArrowArrayPtr = std::shared_ptr;

aditi-pandit · 2025-03-19T06:16:52Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/utils/Utils.cpp

+    const arrow::ArrayVector& arrays) {
+  VELOX_CHECK_EQ(names.size(), arrays.size());
+
+  auto nrows = (!arrays.empty()) ? (arrays[0]->length()) : 0;


Nit : Rename variable to numRows.

aditi-pandit · 2025-03-19T06:21:49Z

...execution/presto_cpp/main/connectors/arrow_flight/tests/utils/ArrowFlightConnectorTestBase.h

+
+static const std::string kFlightConnectorId = "test-flight";
+
+class ArrowFlightConnectorTestBase


Why is this class abstracted ? This class can be combined with the child class below.

I think it was done to have a test base class that doesn't startup a server, but it's not used so I'll combine them

Note that in IBM code we extend this class again to run an integration test against an actual Flight Server - this would be more difficult if the two classes are combined.

@ashkrisk we can't add additional classes in open-source for the only purpose to be internal testing. The base class without the server only registers the connector, that could easily be done in the internal integration tests.

aditi-pandit · 2025-03-19T06:26:05Z

...ive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorAuthTest.cpp

+  std::mutex mutex_;
+};
+
+class TestingAuthenticator : public Authenticator {


Nit : Names TestAuthenticator and TestAuthenticatorFactory are better than usage of verbs like Testing in the name.

.github/workflows/arrow-flight-tests.yml

...to-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightEchoQueries.java

...-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightNativeQueries.java

presto-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightQueries.java

presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowFlightConnector.cpp

majetideepak · 2025-03-20T10:30:57Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/CMakeLists.txt

+# limitations under the License.
+find_package(Arrow REQUIRED)
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(ARROW_FLIGHT REQUIRED IMPORTED_TARGET GLOBAL arrow-flight)


Why choose PkgConfig approach and not how Velox finds Arrow? We should use one approach for consistency.

...rrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightIntegrationSmokeTest.java

czentgr · 2025-02-27T18:58:44Z

.github/workflows/arrow-flight-tests.yml

+            -B _build/release \
+            -GNinja \
+            -DTREAT_WARNINGS_AS_ERRORS=1 \
+            -DENABLE_ALL_WARNINGS=1 \


Arrow flight is behind the flag but it isn't turned on here - RESTO_ENABLE_ARROW_FLIGHT_CONNECTOR
But I doubt we need a complete new job in the first place.

Turn on the flag in the prestocpp-linux-build-and-unit-test.yml and rename the test java file TestPrestoNativeArrowFlightQueries.java. Then it is picked up automatically.
We should add the build flag also to the prestocpp-linux-build.yml

Arrow flight is behind the flag but it isn't turned on here

I do have the flag -DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ON enabled here

rename the test java file TestPrestoNativeArrowFlightQueries.java. Then it is picked up automatically.

This is only if the test is moved to presto-native-execution right?

czentgr · 2025-02-27T19:02:22Z

...-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightNativeQueries.java

@@ -0,0 +1,427 @@
+/*


These are native queries and so should be in the test suite in presto-native-execution - see my other comment on how to change the workflow to get them run regularly without a new job.

@czentgr : I gave this a thought as well ... But then felt that having native as well as java connector tests in the connector module would actually be a good approach. Both implementations cohesively work and test together.

Are there particular reservations about this ?

All of the Java Flight stuff is under the presto-base-arrow-flight module and only tested as part of the arrow-flight-tests workflow. I also thought about adding the native tests to presto-native-execution but there are a lot of things that would be needed from presto-base-arrow-flight which adds a lot to presto-native-execution for just a few tests. So it seemed like it was better to keep in compartmentalized in it's own module.

The native Arrow Flight connector can be used to connect to any Arrow Flight enabled Data Source. The metadata layer is handled by the Presto coordinator and does not need to be re-implemented in C++. Any Java connector that inherits from `presto-base-arrow-flight` can use this connector as it's counterpart for the Prestissimo layer. Different Arrow-Flight enabled data sources can differ in authentication styles. A plugin-style interface is provided to handle such cases with custom authentication code by extending `arrow_flight::auth::Authenticator`. RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0004-arrow-flight-connector.md#prestissimo-implementation Co-authored-by: Ashwin Kumar <[email protected]> Co-authored-by: Rijin-N <[email protected]> Co-authored-by: Nischay Yadav <[email protected]>

This adds e2e tests using the ArrowFlightQueryRunner to run native workers and test queries against a H2 Flight Producer data source. The CI workflow has been updated to add additional steps to build a native presto server with Arrow Flight connector enabled, and run the e2e Java tests with queries taken from AbstractTestNativeGeneralQueries that are compatible with the Flight data source.

majetideepak

All my comments have been addressed. Thanks @BryanCutler

majetideepak · 2025-03-26T15:42:20Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/CMakeLists.txt

+
+add_subdirectory(auth)
+
+add_library(presto_flight_connector_utils INTERFACE Macros.h)


nit: this is only possible from CMake 3.19. Prestissimo minimum CMake version requirement is 3.10. We should bump this up to 3.28 and align with Velox.

aditi-pandit · 2025-03-26T16:46:31Z

...-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightNativeQueries.java

+        }
+    }
+
+    public static Map<String, String> getNativeWorkerSystemProperties()


@BryanCutler : Can we use the functions from PrestoNativeQueryRunnerUtils for getting the properties and external worker launcher instead of repeating the code here ?

That would mean adding a dependency on presto-native-execution, but that should be fine right ?

I thought about that too, the problem is that PrestoNativeQueryRunnerUtils.getExternalWorkerLauncher is setup to use the hive catalog, among other things, so it can't be used as-is. There would have to be some refactoring done to make it usable by both runners. But there really isn't much code that is copied, since here we are setting specific properties for the native arrow connector, so I don't know if it's really worth it to try and reuse this function.

@BryanCutler : I see... That's fair for getExternalWorkerLauncher.

How about getNativeWorkerSystemProperties ? It would be good to use the one in PrestoNativeQueryRunnerUtils so that we don't have to keep the 2 methods in sync.

We could do that as a follow up though.

aditi-pandit

Thanks @BryanCutler

BryanCutler requested review from a team and steveburnett as code owners February 5, 2025 21:47

BryanCutler requested a review from jaystarshot February 5, 2025 21:47

prestodb-ci added the from:IBM PR from IBM label Feb 5, 2025

prestodb-ci requested review from a team, pdabre12 and psnv03 and removed request for a team February 5, 2025 21:47

BryanCutler force-pushed the arrow-connector-native-24082 branch from c9b9df2 to 2418e65 Compare February 5, 2025 21:50

steveburnett requested changes Feb 5, 2025

View reviewed changes

BryanCutler commented Feb 5, 2025

View reviewed changes

BryanCutler force-pushed the arrow-connector-native-24082 branch 2 times, most recently from f6eefb6 to 4b83c44 Compare February 5, 2025 22:12

steveburnett previously approved these changes Feb 5, 2025

View reviewed changes

BryanCutler commented Feb 5, 2025

View reviewed changes

BryanCutler mentioned this pull request Feb 6, 2025

[native] Add Arrow Flight Connector #24082

Closed

6 tasks

BryanCutler dismissed steveburnett’s stale review via 49a3234 February 6, 2025 22:57

BryanCutler force-pushed the arrow-connector-native-24082 branch from 4b83c44 to 49a3234 Compare February 6, 2025 22:57

BryanCutler commented Feb 6, 2025

View reviewed changes

BryanCutler mentioned this pull request Feb 7, 2025

Make ArrowFlightConfig verifyServer true by default #24518

Merged

6 tasks

aditi-pandit reviewed Feb 12, 2025

View reviewed changes

BryanCutler requested a review from aditi-pandit March 10, 2025 22:03

BryanCutler force-pushed the arrow-connector-native-24082 branch from 0272b7b to 00ace62 Compare March 14, 2025 03:05

aditi-pandit reviewed Mar 19, 2025

View reviewed changes

majetideepak reviewed Mar 20, 2025

View reviewed changes

BryanCutler commented Mar 20, 2025

View reviewed changes

...rrow-flight/src/test/java/com/facebook/plugin/arrow/TestArrowFlightIntegrationSmokeTest.java Show resolved Hide resolved

czentgr reviewed Mar 20, 2025

View reviewed changes

BryanCutler force-pushed the arrow-connector-native-24082 branch 2 times, most recently from 3b3ccfa to a607747 Compare March 24, 2025 18:16

majetideepak and others added 3 commits March 24, 2025 14:57

[native] Pass extraCredentials to connector session properties

d0ba56e

BryanCutler force-pushed the arrow-connector-native-24082 branch from a607747 to d03d4ea Compare March 25, 2025 18:29

BryanCutler requested review from aditi-pandit, czentgr and majetideepak March 25, 2025 23:19

majetideepak approved these changes Mar 26, 2025

View reviewed changes

aditi-pandit reviewed Mar 26, 2025

View reviewed changes

aditi-pandit approved these changes Mar 26, 2025

View reviewed changes

BryanCutler mentioned this pull request Mar 27, 2025

Use java matrix for arrow-flight tests #24810

Merged

6 tasks

beinan approved these changes Mar 27, 2025

View reviewed changes

BryanCutler merged commit 4f3da06 into prestodb:master Mar 27, 2025
100 checks passed

BryanCutler deleted the arrow-connector-native-24082 branch March 27, 2025 20:49

majetideepak mentioned this pull request Mar 27, 2025

[native] Pass extraCredentials to connector session properties #22859

Closed

6 tasks

prestodb-ci mentioned this pull request Mar 28, 2025

Add release notes for 0.292 #24825

Merged

30 tasks

majetideepak mentioned this pull request Apr 2, 2025

[native] Fix circular dependency between connector and types #24852

Closed

unidevel mentioned this pull request Apr 25, 2025

Add release notes for 0.292 unix280/presto#23

Closed

30 tasks

BryanCutler mentioned this pull request Apr 30, 2025

[native] ArrowFlight connector missing ColumnHandle operator<() #24914

Merged

6 tasks

This was referenced May 6, 2025

Add release notes for 0.292 unix280/presto#28

Closed

Add release notes for 0.292 unix280/presto#29

Closed

	To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:
	To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:


		namespace facebook::presto::connector {

		void registerAllPrestoConnectors() {


		std::unique_ptr<TestFlightServer> TestFlightServerTest::server;

		TEST_F(TestFlightServerTest, basicTest) {


		static const std::string kFlightConnectorId = "test-flight";

		class ArrowFlightConnectorTestBase


		add_subdirectory(auth)

		add_library(presto_flight_connector_utils INTERFACE Macros.h)

[native] Add Apache Arrow Flight Connector #24504

[native] Add Apache Arrow Flight Connector #24504

Uh oh!

Conversation

BryanCutler commented Feb 5, 2025 • edited by ZacBlanco Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

Uh oh!

steveburnett commented Feb 5, 2025

Uh oh!

BryanCutler commented Feb 5, 2025

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

BryanCutler Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashkrisk Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elbinpallimalilibm Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

BryanCutler commented Feb 5, 2025 •

edited by ZacBlanco

Loading

BryanCutler Feb 5, 2025 •

edited

Loading

ashkrisk Feb 12, 2025 •

edited

Loading

elbinpallimalilibm Feb 7, 2025 •

edited

Loading

BryanCutler Feb 14, 2025 •

edited

Loading