[native]: Add operator override for xxhash64, combine_hash internal functions#24503
Conversation
|
|
|
This pull request was exported from Phabricator. Differential Revision: D68917161 |
…restodb#24503) Summary: TSIA Differential Revision: D68917161
9a5de08 to
660432e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68917161 |
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @pradeepvaka
|
@pradeepvaka : I approved and merged this PR. But I presume you have a bigger PR showing the e2e optimization in native engine. Is that ready yet ? |
|
@aditi-pandit thanks for approval. Join prefilter optimization already exists in Presto but the xxhash_64 and combine_hash internal operators were missing on native. These internal operators were added to velox and the overrides are updated in the commit for e2e to work. |
|
@pradeepvaka : Got you. Can you add some tests in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeJoinQueries.java that will set and test "JOIN_PREFILTER_BUILD_SIDE" system property ? |
…restodb#24503) Summary: TSIA Differential Revision: D68917161
Summary: Add operator override for xxhash64 and combine_hash internal operators to unblock join prefilter optimization for Presto native execution.
Differential Revision: D68917161