Package all resources into query_view_spa.html#24486
Merged
unidevel merged 3 commits intoprestodb:masterfrom Feb 12, 2025
Merged
Package all resources into query_view_spa.html#24486unidevel merged 3 commits intoprestodb:masterfrom
unidevel merged 3 commits intoprestodb:masterfrom
Conversation
Contributor
Author
|
After build page, there are warnings about Related fix => #24374 |
yhwang
previously approved these changes
Feb 4, 2025
yhwang
reviewed
Feb 4, 2025
yhwang
previously approved these changes
Feb 4, 2025
Contributor
Member
|
@ethanyzhang we plan to land the ui-forwardfit PR first to avoid rebase on that one. |
0753d23 to
676214c
Compare
Contributor
Author
|
@yhwang I resolved the conflicts, fix some style issues in SPA page, can you help to review, thanks. |
yhwang
approved these changes
Feb 12, 2025
This was referenced Mar 10, 2025
jp-sivaprasad
pushed a commit
to jp-sivaprasad/presto
that referenced
this pull request
Mar 10, 2025
* Package all resources into query_view_spa.html * refactor filename for query_view_spa.html * Resolve conflicts and fix spa page styles
30 tasks
pradeepvaka
pushed a commit
to pradeepvaka/presto
that referenced
this pull request
Apr 11, 2025
* Package all resources into query_view_spa.html * refactor filename for query_view_spa.html * Resolve conflicts and fix spa page styles
30 tasks
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the pages optimized with chunk spliting, the query_viewer_spa.html will use split chunks instead of packing all resources as SPA page.
Motivation and Context
The pages under dev folder should not use split chunks, so that they can be easily adopted by other system.
The fix will introduce 2 set of configurations (mainConfig and spaConfig) to make both SPA and non SPA pages working as expected.
Impact
UI pages/build, especially the pages under '/dev/' folder
Test Plan
Build & test UI in dev/prod env
Contributor checklist
Release Notes