Skip to content

[native] Advance velox, fix build and unit test.#24470

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:new_vel2
Feb 2, 2025
Merged

[native] Advance velox, fix build and unit test.#24470
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:new_vel2

Conversation

@amitkdutta
Copy link
Contributor

@amitkdutta amitkdutta commented Feb 1, 2025

Fix build issue and unit tests.

@amitkdutta amitkdutta requested a review from a team as a code owner February 1, 2025 13:26
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Feb 1, 2025
@amitkdutta
Copy link
Contributor Author

Seeing a build failure like

[709/769] Building CXX object presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxExpr.cpp.o
FAILED: presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxExpr.cpp.o 
ccache /opt/rh/gcc-toolset-12/root/bin/g++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFOLLY_HAVE_INT128_T=1 -DGFLAGS_IS_A_DLL=0 -DPRESTO_ENABLE_JWT -DPRESTO_ENABLE_REMOTE_FUNCTIONS -DVELOX_DISABLE_GOOGLETEST -I/__w/presto/presto/presto-native-execution/. -I/__w/presto/presto/presto-native-execution/velox -I/__w/presto/presto/presto-native-execution/velox/velox/external/xxhash -I/__w/presto/presto/presto-native-execution/_build/debug/velox -I/__w/presto/presto/presto-native-execution/_build/debug -I/__w/presto/presto/presto-native-execution/_build/debug/_deps/xsimd-src/include -isystem /usr/local/include/proxygen -isystem /usr/include/libdwarf-0 -isystem /__w/presto/presto/presto-native-execution/velox/velox/external/date/velox/external -mavx2 -mfma -mavx -mf16c -mlzcnt -mbmi2 -Wno-nullability-completeness -Wno-deprecated-declarations -Wreorder -Werror -g -std=gnu++17 -MD -MT presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxExpr.cpp.o -MF presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxExpr.cpp.o.d -o presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxExpr.cpp.o -c /__w/presto/presto/presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp
In file included from /__w/presto/presto/presto-native-execution/velox/velox/functions/prestosql/json/SIMDJsonUtil.h:18,
                 from /__w/presto/presto/presto-native-execution/velox/velox/functions/prestosql/types/JsonType.h:19,
                 from /__w/presto/presto/presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp:20:
/__w/presto/presto/presto-native-execution/velox/velox/functions/prestosql/json/SIMDJsonWrapper.h:22:10: fatal error: simdjson.h: No such file or directory
   22 | #include "simdjson.h"
      |          ^~~~~~~~~~~~

CC: @kgpai

@amitkdutta amitkdutta merged commit d4c632a into prestodb:master Feb 2, 2025
60 of 61 checks passed
@amitkdutta amitkdutta changed the title [native] Advance velox. [native] Advance velox, fix build and unit test. Feb 2, 2025
@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants