Skip to content

Conversation

@unidevel
Copy link
Contributor

@unidevel unidevel commented Jan 27, 2025

Description

The commit pushed by the Presto Stable Release Workflow is owned by oss-release-bot which does not exist.

The user and email need to be changed to the prestodb-ci account to ensure commits can be tracked easily.

Motivation and Context

Impact

Release workflow

Test Plan

No plan. (To be verified on the next release)

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 27, 2025
@unidevel unidevel changed the title Update gitconfig in the presto stable release pipeline Update git config in the presto stable release pipeline Jan 27, 2025
@unidevel unidevel requested a review from tdcmeehan January 27, 2025 22:40
@unidevel unidevel marked this pull request as ready for review January 27, 2025 22:40
@unidevel unidevel requested a review from a team as a code owner January 27, 2025 22:40
ethanyzhang
ethanyzhang previously approved these changes Jan 27, 2025
wanglinsong
wanglinsong previously approved these changes Jan 27, 2025
@ethanyzhang ethanyzhang dismissed their stale review January 27, 2025 23:38

Requesting more changes

ethanyzhang
ethanyzhang previously approved these changes Jan 28, 2025
@ethanyzhang
Copy link
Contributor

Hi @tdcmeehan, can you help take a look at this and merge if all looks good?
About the use of environment, please see https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-environments-for-deployment and internal discussion at https://ibm-analytics.slack.com/archives/C0896SRA0FL/p1738020837828909

@unidevel unidevel changed the title Update git config in the presto stable release pipeline Update git config and environment in the presto stable release pipeline Jan 28, 2025
@unidevel
Copy link
Contributor Author

Tested in my env => https://github.com/unix280/presto/actions/runs/13007453636
The settings required =>
image

@tdcmeehan tdcmeehan merged commit 3f4e4c3 into prestodb:master Jan 28, 2025
52 checks passed
shangm2 pushed a commit to shangm2/presto that referenced this pull request Jan 30, 2025
…ne (prestodb#24441)

* Update gitconfig in the presto stable release pipeline

* Add environment for the presto stable release action

* Remove actor checking since the action environment requires approval to run
jp-sivaprasad pushed a commit to jp-sivaprasad/presto that referenced this pull request Mar 10, 2025
…ne (prestodb#24441)

* Update gitconfig in the presto stable release pipeline

* Add environment for the presto stable release action

* Remove actor checking since the action environment requires approval to run
@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants