Skip to content

Comments

Upgrade kafka to 3.9.0#24382

Closed
ZacBlanco wants to merge 2 commits intoprestodb:masterfrom
ZacBlanco:upstream-kafka-upgrade
Closed

Upgrade kafka to 3.9.0#24382
ZacBlanco wants to merge 2 commits intoprestodb:masterfrom
ZacBlanco:upstream-kafka-upgrade

Conversation

@ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Jan 16, 2025 •
edited
Loading

Description

Upgrade kafka in preparation for Java 17 support in Presto

Motivation and Context

Removes dependencies on Zookeeper for testing and modernizes the kafka connector and testing infrastructure.

Impact

  • kafka connector users may require a newer kafka version

Test Plan

existing tests.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

Kafka connector changes
* Upgrade Kafka dependency to 3.9.0. :pr:`24382`

@ZacBlanco
Upgrade kafka to 3.9.0
ec20e45 
This fixes issues with kafka tests failing due to issues in the
zookeeper client code with Java 14+. Upgrading kafka allows
us to deploy an embedded cluster with KRaft instead of ZK
which allows us to remove use of the ZK client codepath in
testing
@ZacBlanco
use apache/kafka image in product-tests
8178db7
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 16, 2025
@prestodb-ci prestodb-ci requested review from a team, auden-woolfson and imsayari404 and removed request for a team January 16, 2025 23:58
@steveburnett
Copy link
Contributor

steveburnett commented Jan 21, 2025

Thanks for the release note! Nit phrasing suggestion

== RELEASE NOTES ==

Kafka Connector Changes
* Upgrade Kafka dependency to 3.9.0. :pr:`24382`

@aaneja aaneja mentioned this pull request Jan 22, 2025
Merged
6 tasks
@ethanyzhang ethanyzhang closed this May 2, 2025
@ethanyzhang
Copy link
Contributor

ethanyzhang commented May 2, 2025 •
edited
Loading

This was upgraded in #24677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auden-woolfson auden-woolfson Awaiting requested review from auden-woolfson auden-woolfson was automatically assigned from prestodb/ibm-reviewers

@imsayari404 imsayari404 Awaiting requested review from imsayari404 imsayari404 was automatically assigned from prestodb/ibm-reviewers

Assignees

No one assigned

Labels

from:IBM PR from IBM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZacBlanco @steveburnett @ethanyzhang @prestodb-ci