Skip to content

Comments

Revert "Add native plan checker to sidecar plugin"#24192

Closed
rschlussel wants to merge 1 commit intoprestodb:masterfrom
rschlussel:revert-native-plan-checker
Closed

Revert "Add native plan checker to sidecar plugin"#24192
rschlussel wants to merge 1 commit intoprestodb:masterfrom
rschlussel:revert-native-plan-checker

Conversation

@rschlussel
Copy link
Contributor

This reverts commit f3b2f52 from #23596 until a new presto-maven-plugin release is ready that includes prestodb/presto-maven-plugin#19.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Dec 3, 2024
@tdcmeehan
Copy link
Contributor

tdcmeehan commented Dec 4, 2024

rschlussel can you share some more details on why we need to revert?. I see the reasoning on the original PR and now understand better, have left a comment there.

@rschlussel rschlussel closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants