Skip to content

Security Vulnerability fix for snappy-0.2(CVE-2024-36124) #24159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
namya28 wants to merge 1 commit into from
Closed

Security Vulnerability fix for snappy-0.2(CVE-2024-36124) #24159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,12 @@

<dependencyManagement>
<dependencies>
<dependency>
Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is ultimately bringing in and using this dependency?

Copy link
Copy Markdown
Contributor Author

@namya28 namya28 Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdcmeehan The version earlier used was 0.2 which was present transitively across modules , causing the vulnerability. By bringing in this dependency and the version 0.5 fixes the vulnerability as 0.5 is the vulnerable free version for this library.

Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but my question is what is using it?

Copy link
Copy Markdown
Contributor Author

@namya28 namya28 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being transitively used by the modules presto-hive-hadoop2 , presto-hive , presto-native-execution and presto-hive-metastore . (Attaching a screenshot for reference)
Screenshot 2024-12-04 at 9 43 18 PM

Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update hive-dwrf instead of overriding it at the top level here?

Copy link
Copy Markdown
Contributor Author

@namya28 namya28 Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdcmeehan , introducing the latest version of hive-dwrf introduces a lot of vulnerabilities. (https://mvnrepository.com/artifact/com.facebook.hive/hive-dwrf/0.18.9). (Attaching the screenshot from the maven repository). Although even if we try upgrading hive-dwrf, it does not resolve the vulnerability directly as it still introduces the 0.2 version of snappy transitively.
Screenshot 2024-12-05 at 8 49 08 PM

Copy link
Copy Markdown
Contributor Author

@namya28 namya28 Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdcmeehan , could you please have a look at the comments and re-review if possible?

Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is, simply fix the vulnerabilities in hive-dwrf, cut a release, then update here. https://github.com/prestodb/presto-hive-dwrf

<groupId>org.iq80.snappy</groupId>
<artifactId>snappy</artifactId>
<version>0.5</version>
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
Expand Down