[native] Add LinuxMemoryChecker check/warning to ensure system-mem-limit-gb is reasonably set #24149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

czentgr merged 1 commit into prestodb:master from minhancao:linuxmemorychecker_mem_limit_check

Feb 27, 2025

Contributor

minhancao commented Nov 26, 2024 •

edited

Loading

Description

Add additional checks and warnings to ensure
system-memory-gb <= system-mem-limit-gb < available machine memory of deployment.

For cgroup v1:
Set available machine memory of deployment to be the smaller number
between /proc/meminfo and memory.limit_in_bytes.

For cgroup v2:
Set available machine memory of deployment to be the smaller number
between /proc/meminfo and memory.max.
If memory.max contains "max" string, then look at
/proc/meminfo for the MemTotal, otherwise use the
value in memory.max.

Motivation and Context

Impact

Test Plan

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo (Native Execution)
* Replace default values for configuration properties ``system-memory-gb`` to 57 
  and ``system-mem-limit-gb`` to 60.

Documentation
* Replace default values for configuration properties ``system-memory-gb`` to 57 
  and ``system-mem-limit-gb`` to 60.

minhancao self-assigned this

prestodb-ci added the from:IBM label

prestodb-ci requested review from a team, pramodsatya and psnv03 and removed request for a team

November 26, 2024 02:04

minhancao requested review from czentgr and majetideepak

November 26, 2024 02:05

minhancao marked this pull request as ready for review

November 26, 2024 02:07

minhancao requested a review from a team as a code owner

November 26, 2024 02:07

minhancao changed the title ~~[native] Add LinuxMemoryChecker warnings to ensure system-memory-gb < system-mem-limit-gb < actual total memory capacity~~ [native] Add LinuxMemoryChecker warnings to ensure system-mem-limit-gb is reasonably set

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 4478ae1 to 15f55bb Compare

November 26, 2024 02:29

minhancao changed the title ~~[native] Add LinuxMemoryChecker warnings to ensure system-mem-limit-gb is reasonably set~~ [native] Add LinuxMemoryChecker check/warning to ensure system-mem-limit-gb is reasonably set

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 15f55bb to 7646600 Compare

November 26, 2024 06:06

czentgr reviewed

View reviewed changes

Contributor

czentgr left a comment

Can we add a test with fake files again just like we did with the original tests for this class?
That way we can try the "max" value for cgv2, and gigantic values and reasonable values. Basically testing the various situations we saw when investigating this.

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch 2 times, most recently from 8da401b to 4ae2cee Compare

December 3, 2024 20:08

pramodsatya reviewed

View reviewed changes

Contributor

pramodsatya left a comment

Thanks @minhancao, could you please squash the commits?

presto-native-execution/presto_cpp/main/tests/LinuxMemoryCheckerTest.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Show resolved Hide resolved

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 85b3b9d to dab2335 Compare

December 13, 2024 00:00

majetideepak previously requested changes

View reviewed changes

Collaborator

majetideepak left a comment

It is ideal if we can avoid checking in data files for testing.
We only need a few fields from the file for testing.
Can we write these required fields to a temporary file as part of the testing?

czentgr reviewed

View reviewed changes

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/tests/examples/cgroupV1memoryNotSet.limit_in_bytes Outdated Show resolved Hide resolved

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch 2 times, most recently from 71c9fa9 to 89a50a8 Compare

January 16, 2025 23:53

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 89a50a8 to 163880b Compare

January 22, 2025 18:16

czentgr reviewed

View reviewed changes

presto-native-execution/presto_cpp/main/tests/LinuxMemoryCheckerTest.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/tests/LinuxMemoryCheckerTest.cpp Outdated Show resolved Hide resolved

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 163880b to 29dc3b5 Compare

January 28, 2025 00:40

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch 2 times, most recently from 9a7cbf7 to 80ca9b5 Compare

February 6, 2025 22:25

Contributor Author

minhancao commented Feb 6, 2025

@czentgr @majetideepak @pramodsatya
I have addressed all the PR comments, please review this PR when you can, thank you!

czentgr reviewed

View reviewed changes

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

minhancao dismissed stale reviews from majetideepak and czentgr via

79d104c

February 18, 2025 18:45

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 4d982e6 to 79d104c Compare

February 18, 2025 18:45

jaystarshot previously approved these changes

View reviewed changes

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 79d104c to f3920ad Compare

February 18, 2025 22:13

majetideepak previously approved these changes

View reviewed changes

Collaborator

majetideepak commented Feb 18, 2025

@minhancao CI is failing. Please verify before merging.

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from f3920ad to 7c8e159 Compare

February 19, 2025 02:42

minhancao dismissed stale reviews from majetideepak and jaystarshot via

fa8f2dc

February 19, 2025 23:25

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch 4 times, most recently from 4df91c3 to e4c2d31 Compare

February 25, 2025 00:17

Contributor Author

minhancao commented Feb 25, 2025

@czentgr @majetideepak @jaystarshot
I have fixed the CI failure. Please review this PR one more time, thank you!

czentgr reviewed

View reviewed changes

presto-docs/src/main/sphinx/presto_cpp/properties.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/presto_cpp/properties.rst Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/LinuxMemoryChecker.cpp Outdated Show resolved Hide resolved

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from e4c2d31 to 6271440 Compare

February 26, 2025 20:31


          [native] Add LinuxMemoryChecker check/warning to ensure system-mem-li…

8ea4c76

…mit-gb is reasonably set

Add additional checks and warnings to ensure
system-memory-gb <= system-mem-limit-gb < available machine memory of deployment.

For cgroup v1:
Set available machine memory of deployment to be the smaller number
between /proc/meminfo and memory.limit_in_bytes.

For cgroup v2:
Set available machine memory of deployment to be the smaller number
between /proc/meminfo and memory.max.
If memory.max contains "max" string, then look at
/proc/meminfo for the MemTotal, otherwise use the
value in memory.max.

minhancao force-pushed the linuxmemorychecker_mem_limit_check branch from 6271440 to 8ea4c76 Compare

February 26, 2025 21:12

majetideepak approved these changes

View reviewed changes

Collaborator

majetideepak commented Feb 27, 2025

@jaystarshot can you please approve this PR again? CI is now passing.

jaystarshot approved these changes

View reviewed changes

czentgr approved these changes

View reviewed changes

czentgr merged commit 40fe92e into prestodb:master

61 checks passed

This was referenced Mar 10, 2025

Add release notes for 0.292 unix280/presto#5

Closed

Add release notes for 0.292 unix280/presto#6

Closed

prestodb-ci mentioned this pull request

Add release notes for 0.292 #24825

Merged

30 tasks

unidevel mentioned this pull request

Add release notes for 0.292 unix280/presto#23

Closed

30 tasks

This was referenced May 6, 2025

Add release notes for 0.292 unix280/presto#28

Closed

Add release notes for 0.292 unix280/presto#29

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pramodsatya pramodsatya left review comments

majetideepak majetideepak approved these changes

jaystarshot jaystarshot approved these changes

czentgr czentgr approved these changes

steveburnett steveburnett left review comments

psnv03 Awaiting requested review from psnv03 psnv03 was automatically assigned from prestodb/ibm-reviewers

elharo Awaiting requested review from elharo elharo is a code owner

presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Labels