Add overflow detection to IntervalYearMonthOperators #24089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdcmeehan
force-pushed
the
intervalym
branch
2 times, most recently
from
10d59aa to
c58bf94
Compare
Member
hantangwangd
left a comment
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for the fix, looks good to me, only some nits.
presto-main/src/main/java/com/facebook/presto/type/IntervalYearMonthOperators.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/type/IntervalYearMonthOperators.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/type/TestIntervalYearMonth.java
Outdated
Show resolved
Hide resolved
tdcmeehan
force-pushed
the
intervalym
branch
from
c58bf94 to
5c50738
Compare
Contributor
Author
|
Thanks for the review @hantangwangd, I have updated the PR. |
hantangwangd
approved these changes
Nov 22, 2024
Member
hantangwangd
left a comment
hantangwangd
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix.
Contributor
|
Closing this PR as the change is merged in #24617. |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Apr 17, 2025
Summary: Add support for mathematical functions `plus`, `minus`, `multiply`, and `divide` with `IntervalYearMonth` type. The function signatures added match that of [Presto](https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/type/IntervalYearMonthOperators.java), accounting for the Presto function signature changes in prestodb/presto#24089. Pull Request resolved: #11612 Reviewed By: pedroerp Differential Revision: D72997442 Pulled By: kKPulla fbshipit-source-id: 5fcf40639ed0af63e6ec198994aeaef49ba367cb
zhanglistar
pushed a commit
to bigo-sg/velox
that referenced
this pull request
Apr 22, 2025
…incubator#11612) Summary: Add support for mathematical functions `plus`, `minus`, `multiply`, and `divide` with `IntervalYearMonth` type. The function signatures added match that of [Presto](https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/type/IntervalYearMonthOperators.java), accounting for the Presto function signature changes in prestodb/presto#24089. Pull Request resolved: facebookincubator#11612 Reviewed By: pedroerp Differential Revision: D72997442 Pulled By: kKPulla fbshipit-source-id: 5fcf40639ed0af63e6ec198994aeaef49ba367cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #24087
Motivation and Context
Fix incorrect data caused by overflow, and correct the type mapping in certain operators.
Impact
Where previously some expressions could have resulted in an overflow and incorrect results, now they will fail with a
NUMERIC_VALUE_OUT_OF_RANGEerror.Test Plan
Unit tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.