Skip to content

[native] Remove native session native_join_spill_partition_bits #23906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxmeng merged 1 commit into from
Oct 29, 2024
Merged

[native] Remove native session native_join_spill_partition_bits #23906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions presto-native-execution/presto_cpp/main/SessionProperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,18 +175,10 @@ SessionProperties::SessionProperties() {
QueryConfig::kRowNumberSpillEnabled,
boolToString(c.rowNumberSpillEnabled()));

addSessionProperty(
kJoinSpillPartitionBits,
"Native Execution only. The number of bits (N) used to calculate the "
"spilling partition number for hash join and RowNumber: 2 ^ N",
INTEGER(),
false,
QueryConfig::kJoinSpillPartitionBits,
std::to_string(c.rowNumberSpillEnabled()));

addSessionProperty(
kSpillerNumPartitionBits,
"none",
"The number of bits (N) used to calculate the spilling "
"partition number for hash join and RowNumber: 2 ^ N",
TINYINT(),
false,
QueryConfig::kSpillNumPartitionBits,
Expand Down
7 changes: 2 additions & 5 deletions presto-native-execution/presto_cpp/main/SessionProperties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,8 @@ class SessionProperties {
static constexpr const char* kWriterSpillEnabled =
"native_writer_spill_enabled";

/// The number of bits (N) used to calculate the spilling
/// partition number for hash join and RowNumber: 2 ^ N
static constexpr const char* kJoinSpillPartitionBits =
"native_join_spiller_partition_bits";

/// The number of bits (N) used to calculate the spilling partition number for
/// hash join and RowNumber: 2 ^ N
static constexpr const char* kSpillerNumPartitionBits =
"native_spiller_num_partition_bits";

Expand Down