[native] Removing status message from native worker to support http/2#23653
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Sep 19, 2024
Merged
[native] Removing status message from native worker to support http/2#23653amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta merged 1 commit intoprestodb:masterfrom
Conversation
gggrace14
changed the title
gggrace14
previously approved these changes
Sep 16, 2024
Collaborator
|
@amitkdutta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
amitkdutta
changed the title
gggrace14
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/2 does not use status message. We recently migrated to new jetty server that uses http2 (#23356). From native worker, passing status message is no op. In some cases we parse the error message and pick the first line as message. This is not necessary as status message is not used. Proxygen's RequestBuilder::status function expects status message and sets http version 1/1 hard coded. However, after discussing with proxygen folks, found that they intentially set it and proxygen does not depend on this version number, instead they use server next protocol/client next protocol.
Extensive testing is done with shadow tests, also existing e2e tests pass.