Skip to content

[docs] fix formatting in presto-cpp/features.rst#23636

Merged
steveburnett merged 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-fix-cpp-features.rst
Sep 12, 2024
Merged

[docs] fix formatting in presto-cpp/features.rst#23636
steveburnett merged 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-fix-cpp-features.rst

Conversation

@steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Sep 12, 2024

Description

Fix formatting errors in presto-cpp/features.rst that create the following warnings in local doc build:

/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/features.rst:277: WARNING: Title underline too short.

``native_debug_disable_expression_with_peeling``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/features.rst:277: WARNING: Title underline too short.

``native_debug_disable_expression_with_peeling``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/features.rst:297: WARNING: Title underline too short.

``native_debug_disable_expression_with_memoization``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/features.rst:297: WARNING: Title underline too short.

``native_debug_disable_expression_with_memoization``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/features.rst:308: WARNING: Title underline too short.

``native_debug_disable_expression_with_lazy_inputs``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/features.rst:308: WARNING: Title underline too short.

``native_debug_disable_expression_with_lazy_inputs``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Motivation and Context

Builds on work in #23210, #23090, #23033, #22876, and #22985.

Like the doc build errors I fixed in the other PRs, these errors don't stop the build but they're annoying, and these are easy and low-risk fixes.

Impact

Reduces warnings in doc builds, making them run faster.

Test Plan

Local doc builds.

Before:
Six errors above display, and total build succeeded, 19 warnings.

After: The six errors are not displayed, and total build succeeded, 13 warnings.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett requested review from a team and elharo as code owners September 12, 2024 15:06
@steveburnett steveburnett self-assigned this Sep 12, 2024
@github-actions github-actions bot added the docs label Sep 12, 2024
@steveburnett steveburnett merged commit 1167b1e into prestodb:master Sep 12, 2024
@steveburnett steveburnett deleted the steveburnett-fix-cpp-features.rst branch September 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants