Skip to content

[native] Advance velox.#23611

Closed
amitkdutta wants to merge 1 commit intoprestodb:masterfrom
amitkdutta:vel8
Closed

[native] Advance velox.#23611
amitkdutta wants to merge 1 commit intoprestodb:masterfrom
amitkdutta:vel8

Conversation

@amitkdutta
Copy link
Copy Markdown
Contributor

== NO RELEASE NOTE ==

@amitkdutta amitkdutta requested a review from a team as a code owner September 10, 2024 03:38
Copy link
Copy Markdown
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkdutta thanks!

@aditi-pandit
Copy link
Copy Markdown
Contributor

linux-presto-e2e-tests has failed : [ERROR] TestPrestoNativeIcebergTpcdsQueriesParquetUsingThrift.doDeletesAndQuery:400->runAllQueries:126->AbstractTestNativeTpcdsQueries.testTpcdsQ76:1010->AbstractTestQueryFramework.assertQuery:169 Execution of 'actual' query failed: SELECT

@imjalpreet @agrawalreetika @nmahadevuni : Please can you take a look.

@nmahadevuni
Copy link
Copy Markdown
Member

nmahadevuni commented Sep 10, 2024

Failing with error from Velox Caused by: VeloxRuntimeError: rawResultNulls_ && rawValues_ . Looks like something changed from previous velox commit that's causing this. Trying to find out which commit caused this.

@nmahadevuni
Copy link
Copy Markdown
Member

nmahadevuni commented Sep 10, 2024

Commit [24dd2e9382f74389ae01968a1350a2d01bdb6785](https://github.com/facebookincubator/velox/commit/24dd2e9382f74389ae01968a1350a2d01bdb6785) (Table scan execution path code cleanup (#10893)) is causing this issue with TPCDS-Q76. @xiaoxmeng

@nmahadevuni
Copy link
Copy Markdown
Member

Can reproduce with IcebergExternalQueryRunner by using the below query

SELECT ss_ext_sales_price FROM store_sales WHERE ("ss_store_sk" IS NULL);

@amitkdutta
Copy link
Copy Markdown
Contributor Author

Thanks folks for jumping in. @xiaoxmeng fixed it in facebookincubator/velox#10956
Closing this one since we have a more recent velox commit PR including the fix #23621

@amitkdutta amitkdutta closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants