Function to split an IP prefix into subnets#23515
Closed
matt-calder wants to merge 1 commit intoprestodb:masterfrom
Closed
Function to split an IP prefix into subnets#23515matt-calder wants to merge 1 commit intoprestodb:masterfrom
matt-calder wants to merge 1 commit intoprestodb:masterfrom
Conversation
matt-calder
requested review from
a team,
elharo and
steveburnett
as code owners
elharo
reviewed
Aug 26, 2024
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
steveburnett
previously approved these changes
Aug 26, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
5c5ecef to
d2ea3ba
Compare
yingsu00
reviewed
Aug 27, 2024
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
d2ea3ba to
54101b9
Compare
yingsu00
reviewed
Aug 28, 2024
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
54101b9 to
c6e736e
Compare
elharo
reviewed
Aug 29, 2024
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
c6e736e to
8b7ba4d
Compare
steveburnett
previously approved these changes
Sep 3, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
(Re-review after close and reopening.)
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
8b7ba4d to
92db252
Compare
steveburnett
previously approved these changes
Sep 3, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
(rerereview by request)
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
kaikalur
reviewed
Sep 4, 2024
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/scalar/IpPrefixFunctions.java
Show resolved
Hide resolved
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
92db252 to
ca2ef33
Compare
steveburnett
previously approved these changes
Sep 6, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
tests and docs reviewer feedback 2 improved documentation converting comment styles feedback changing return type when prefix_length arg is less specific that input prefix reviewer feedback removing whitespace
matt-calder
force-pushed
the
mattcalder-ip-prefix-subnets
branch
from
d73d51d to
cf05a91
Compare
Contributor
Author
|
I was unable to squash and merge this correctly so this branch is FUBAR. Abandoning for new PR. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a function
ip_prefix_subnetsthat, given an inputip_prefixand a subnetprefix_length, splits the IP prefix into subnets of the input prefix length. The functions return an array of new prefixes of the new input prefix length.This is a complimentary sister function to the
ip_prefix_collapsefunction.Motivation and Context
This change addresses issue 23514.
Impact
This change introduces a new user-facing function
ip_prefix_subnets.Test Plan
Unit tests
mvn clean install -Dtest=TestIpPrefixFunctions -Dmaven.javadoc.skip=true -DskipUI -T1C -fn -pl presto-mainContributor checklist