Skip to content

[native] Comment out failing tests temporarely.#23458

Merged
spershin merged 1 commit intoprestodb:masterfrom
spershin:DisableFailingTests
Aug 16, 2024
Merged

[native] Comment out failing tests temporarely.#23458
spershin merged 1 commit intoprestodb:masterfrom
spershin:DisableFailingTests

Conversation

@spershin
Copy link
Copy Markdown
Contributor

Description

The commented out parts are failing in Meta's internal environment.
We are commenting them out until we figure out why.

== NO RELEASE NOTE ==

@spershin spershin requested a review from a team as a code owner August 16, 2024 00:13
@amitkdutta
Copy link
Copy Markdown
Contributor

@aditi-pandit @nmahadevuni These 2 tests seems flaky in Meta internal system. We are yet to figure out exact reason, but working on it. @xiaoxmeng Left a comment here #23411 (comment)
You folks any thoughts about it? Let us know if its ok to disable for now.

Copy link
Copy Markdown
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spershin thanks!

@spershin spershin merged commit 4dab583 into prestodb:master Aug 16, 2024
@nmahadevuni
Copy link
Copy Markdown
Member

Thanks. It should be fine to disable it. I have tried multiple runs and checked the table contents. I see no reason why this should fail.

@spershin
Copy link
Copy Markdown
Contributor Author

I checked last night.
The tests are fine by themselves.

The tests are failing due to presto-facebook using different classes to implement splits and they don't have this support for size and date fields.
I will add the necessary support, ensure that tests are succeeding and then re-enable the commented parts.

@nmahadevuni , @xiaoxmeng , @amitkdutta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants