[native] Comment out failing tests temporarely.#23458
Merged
spershin merged 1 commit intoprestodb:masterfrom Aug 16, 2024
Merged
[native] Comment out failing tests temporarely.#23458spershin merged 1 commit intoprestodb:masterfrom
spershin merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
|
@aditi-pandit @nmahadevuni These 2 tests seems flaky in Meta internal system. We are yet to figure out exact reason, but working on it. @xiaoxmeng Left a comment here #23411 (comment) |
xiaoxmeng
approved these changes
Aug 16, 2024
Member
|
Thanks. It should be fine to disable it. I have tried multiple runs and checked the table contents. I see no reason why this should fail. |
Contributor
Author
|
I checked last night. The tests are failing due to presto-facebook using different classes to implement splits and they don't have this support for size and date fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The commented out parts are failing in Meta's internal environment.
We are commenting them out until we figure out why.