[native] Add a sample plan validator and e2e tests.#23439
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Aug 21, 2024
Merged
[native] Add a sample plan validator and e2e tests.#23439amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
|
@amitkdutta @pedroerp : Cross posting my comment #23423 (comment) for a sample plan validator. |
amitkdutta
force-pushed
the
dummy_test
branch
10 times, most recently
from
484acc5 to
d794878
Compare
Collaborator
|
@amitkdutta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
amitkdutta
force-pushed
the
dummy_test
branch
3 times, most recently
from
e437b57 to
8d89141
Compare
xiaoxmeng
reviewed
Aug 21, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@amitkdutta LGTM. Thanks!
amitkdutta
force-pushed
the
dummy_test
branch
2 times, most recently
from
c9c20d8 to
a72b7ad
Compare
amitkdutta
changed the title
amitkdutta
changed the title
xiaoxmeng
previously approved these changes
Aug 21, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@amitkdutta LGTM % nits.
presto-native-execution/presto_cpp/main/types/VeloxPlanValidator.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/VeloxPlanValidator.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/VeloxPlanValidator.cpp
Outdated
Show resolved
Hide resolved
xiaoxmeng
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a sample validator in worker that fails if plan has nested loop join. We also address comments around naming as in #23423 (comment)
Motivation and Context
Adding a sample validaotr shows how the validation interface can used.
Impact
None
Test Plan
E2E tests