[native] Add metrics for memory pushback mechanism#23422
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Aug 13, 2024
Merged
[native] Add metrics for memory pushback mechanism#23422xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng merged 1 commit intoprestodb:masterfrom
Conversation
tanjialiang
force-pushed
the
pushback_metrics
branch
from
87a078f to
0d4b978
Compare
xiaoxmeng
reviewed
Aug 12, 2024
| if (config_.systemMemPushbackEnabled && | ||
| systemUsedMemoryBytes() > config_.systemMemLimitBytes) { | ||
| pushbackMemory(); | ||
| RECORD_METRIC_VALUE(kCounterMemoryPushbackCount); |
Contributor
There was a problem hiding this comment.
How about handle this inside pushbackMemory()? Thanks!
Contributor
|
@tanjialiang : Please add a release note for this change since you are adding user-visible metrics. |
tanjialiang
force-pushed
the
pushback_metrics
branch
from
0d4b978 to
8925f2e
Compare
xiaoxmeng
previously approved these changes
Aug 12, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@tanjialiang LGTM. Thanks for the update!
|
|
||
| /// ================== Memory Pushback Counters ================= | ||
|
|
||
| /// Number of times memory pushback mechanism is triggered. |
Contributor
There was a problem hiding this comment.
Consider to add document for Presitssimo metrics as Velox does in followup. Thanks!
tanjialiang
force-pushed
the
pushback_metrics
branch
from
8925f2e to
890c76d
Compare
xiaoxmeng
approved these changes
Aug 13, 2024
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds 2 memory push back related metrics to the system. One pushback count, one pushback latency. This will help us understand how pushback mechanism works in our system and what could be improved.
Following 2 metrics were added in Presto Native: