Fix like matching with newlines and no wildcard

[rschlussel]

Description

LIKE expressions were not looking past newlines when there was no wild card. That means that certain expressions were incorrectly returning matches when after the newline the input did not match. This change fixes that behavior. For example:

SELECT 'foo\nbar' LIKE 'foo'.

Previously that query would return "true". Now it will return false.

Motivation and Context

Fixes #23281

Fixes a bug with like expressions incorrectly matching only to a newline when there is no wildcard.

Impact

Like expressions with patterns that do not end in a wildcard may now return false when previously they would return true

Test Plan

unit tests
verification on our production workload

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Fix a bug where like predicates would only match to a newline when there was no wildcard at the end. :pr:`23404`

[jp-sivaprasad]

Suggested additional tests

@Test
public void testLikeNewlineAtMatch()
{
    Regex regex = likePattern(utf8Slice("foo_bar"));
    assertTrue(likeVarchar(utf8Slice("foo\nbar"), regex));
}

@Test
public void testLikeNewlineInMatchWithSingle()
{
    Regex regex = likePattern(utf8Slice("fo_%"));
    assertTrue(likeVarchar(utf8Slice("foo\nbar"), regex));
}

cc @tdcmeehan

[steveburnett]

LGTM! (docs)

Pull branch, new local doc build, looks good. Thanks!

[steveburnett]

Nit, suggest adding the PR number to the release note entry

== RELEASE NOTES ==

General Changes
* Fix a bug where like predicates would only match to a newline when there was no wildcard at the end. :pr:`23404`

[rschlussel]

Suggested additional tests

@Test
public void testLikeNewlineAtMatch()
{
    Regex regex = likePattern(utf8Slice("foo_bar"));
    assertTrue(likeVarchar(utf8Slice("foo\nbar"), regex));
}

@Test
public void testLikeNewlineInMatchWithSingle()
{
    Regex regex = likePattern(utf8Slice("fo_%"));
    assertTrue(likeVarchar(utf8Slice("foo\nbar"), regex));
}

cc @tdcmeehan

@jp-sivaprasad Thanks for the review! I added the first test. The second case I felt the existing newline tests with wildcards provided enough coverage, so I left it out. Also, I see now that you had assigned this issue to yourself. Sorry for not coordinating with you first!

[facebook-github-bot]

@rschlussel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[hantangwangd]

Looks good to me, some little nits.

[facebook-github-bot]

@rschlussel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.