Skip to content

[native] Enhance CSV Parsing in ContainerQueryRunner to Use MaterializedResult#23382

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
Joe-Abraham:parse_csv
Aug 12, 2024
Merged

[native] Enhance CSV Parsing in ContainerQueryRunner to Use MaterializedResult#23382
tdcmeehan merged 1 commit intoprestodb:masterfrom
Joe-Abraham:parse_csv

Conversation

@Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Aug 5, 2024

Resolves: #23086

@Joe-Abraham Joe-Abraham requested review from a team and steveburnett as code owners August 5, 2024 14:24
@Joe-Abraham Joe-Abraham requested a review from presto-oss August 5, 2024 14:24
@Joe-Abraham Joe-Abraham marked this pull request as draft August 5, 2024 14:25
@Joe-Abraham Joe-Abraham force-pushed the parse_csv branch 2 times, most recently from 73f86c4 to bcd6501 Compare August 5, 2024 14:28
@Joe-Abraham Joe-Abraham changed the title [native] Improve csv parsing to MaterializedResult in ContainerQueryRunner [native] Enhance CSV Parsing in ContainerQueryRunner to Use MaterializedResult Aug 5, 2024
@Joe-Abraham
Copy link
Contributor Author

@tdcmeehan Can you please have a look?

@Joe-Abraham Joe-Abraham marked this pull request as ready for review August 5, 2024 14:54
@tdcmeehan tdcmeehan self-assigned this Aug 5, 2024
@Joe-Abraham Joe-Abraham requested a review from tdcmeehan August 6, 2024 06:10
@steveburnett steveburnett removed their request for review August 6, 2024 15:27
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more nit.

@Joe-Abraham Joe-Abraham force-pushed the parse_csv branch 2 times, most recently from f45d279 to 5493c48 Compare August 8, 2024 02:52
@tdcmeehan tdcmeehan merged commit 88ef79d into prestodb:master Aug 12, 2024
@Joe-Abraham Joe-Abraham deleted the parse_csv branch August 14, 2024 06:49
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Presto needs a modern functional testing framework that runs tests using real infrastructure

3 participants