array_min/array_max throw if first element is an inner Array with a null

[kevinwilfong]

Description

array_min and array_max will always throw an exception if the first element is an inner array with a null.

Motivation and Context

array_min and array_max always compare the first element with itself. Besides being unnecessary this produces inconsistent behavior where if the first element is an array (or there is an array recursively in a complex type) that contains a null the function will throw "ARRAY comparison not supported for arrays with null elements".

This is because the element is of course equal to itself, but everything in it needs to be compared to verify this.

For other elements, the comparison will exit early as soon as it can be confirmed that it is less than/greater than the current candidate, so it may not throw even if it contains an array with a null element.

Impact

This should slightly improve performance by avoiding an unnecessary comparison, but will also cause the function to throw only if it needs to compare a null element of an inner array in the first element with the corresponding value in a later element.

Test Plan

Added unit tests to verify a null in the first element does not necessarily cause the function to throw, but it does throw if it is necessary to compare that null with another value.

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

== RELEASE NOTES ==

General Changes
* Fix array_min/array_max to not necessarily throw if the first element recursively contains an inner array with a null element. :pr:`23323`

[elharo]

Are these functions documented somewhere? If so, does that need to be updated?

[elharo]

Can we have new test methods instead please? Makes it easier to debug failures.

[kevinwilfong]

@elharo Thanks for the review!

The functions are documented here

presto/presto-docs/src/main/sphinx/functions/array.rst

Lines 123 to 129 in 772213c

	.. function:: array_max(x) -> x
	Returns the maximum value of input array.
	.. function:: array_min(x) -> x
	Returns the minimum value of input array.

But it does not say anything about this behavior that would need to be updated.

[kevinwilfong]

The failing check appears to be some TestHudiIntegration tests that are broken in trunk #22031

[elharo]

These should be four separate test methods so they can pass or fail independently.