Fix Iceberg read failing for Decimal type

[wypb]

Description

Fix #23274

After the introduction of the decimal batch reader(#22636) in Presto, when trying to read iceberg tables with decimal columns with parquet_batch_read_optimization_enabled=true, we are getting the below error

java.lang.ClassCastException: com.facebook.presto.parquet.batchreader.decoders.rle.Int32RLEDictionaryValuesDecoder cannot be cast to com.facebook.presto.parquet.batchreader.decoders.ValuesDecoder$ShortDecimalValuesDecoder
	at com.facebook.presto.parquet.batchreader.ShortDecimalFlatBatchReader.readNextPage(ShortDecimalFlatBatchReader.java:139)
	at com.facebook.presto.parquet.batchreader.ShortDecimalFlatBatchReader.readWithNull(ShortDecimalFlatBatchReader.java:156)
	at com.facebook.presto.parquet.batchreader.ShortDecimalFlatBatchReader.readNext(ShortDecimalFlatBatchReader.java:104)
	at com.facebook.presto.parquet.reader.ParquetReader.readPrimitive(ParquetReader.java:389)
	at com.facebook.presto.parquet.reader.ParquetReader.readColumnChunk(ParquetReader.java:550)
	at com.facebook.presto.parquet.reader.ParquetReader.readBlock(ParquetReader.java:533)
	at com.facebook.presto.hive.parquet.ParquetPageSource$ParquetBlockLoader.load(ParquetPageSource.java:230)
	at com.facebook.presto.hive.parquet.ParquetPageSource$ParquetBlockLoader.load(ParquetPageSource.java:208)
	at com.facebook.presto.common.block.LazyBlock.assureLoaded(LazyBlock.java:313)
	at com.facebook.presto.common.block.LazyBlock.getLoadedBlock(LazyBlock.java:304)
	at com.facebook.presto.common.Page.getLoadedPage(Page.java:335)
	at com.facebook.presto.operator.TableScanOperator.getOutput(TableScanOperator.java:269)
	at com.facebook.presto.operator.Driver.processInternal(Driver.java:441)
	at com.facebook.presto.operator.Driver.lambda$processFor$10(Driver.java:324)
	at com.facebook.presto.operator.Driver.tryWithLock(Driver.java:750)
	at com.facebook.presto.operator.Driver.processFor(Driver.java:317)
	at com.facebook.presto.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:1079)
	at com.facebook.presto.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:165)
	at com.facebook.presto.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:621)
	at com.facebook.presto.$gen.Presto_null__testversion____20240722_195546_1.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

The issue happens when trying to read dictionary-encoded data.

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

Iceberg Connector Changes
* Fix Iceberg read failing for Decimal type. :pr:`23305`

CC: @tdcmeehan @yingsu00 @imjalpreet

[imjalpreet]

@wypb Thank you for the fix.

Can you please force-push once to retrigger the entire suite again? Looks like there were some intermittent issues.

[imjalpreet]

Let's move this after line 43 and please add @VisibleForTesting

[wypb]

Fixed.

[imjalpreet]

We can also add a generic test with this feature enabled in the iceberg connector which also tries reading other datatypes in addition to decimal.

[hantangwangd]

Thanks for the fix. LGTM!

[imjalpreet]

LGTM, thanks for adding the tests.