Skip to content

Fix for Pull request 23127#23304

Merged
abhiseksaikia merged 1 commit intoprestodb:masterfrom
agrawaldevesh:fix_23127
Jul 26, 2024
Merged

Fix for Pull request 23127#23304
abhiseksaikia merged 1 commit intoprestodb:masterfrom
agrawaldevesh:fix_23127

Conversation

@agrawaldevesh
Copy link
Contributor

Description

Fixing the issue I described in #23127 (comment)

Motivation and Context

presto-jdbc is supposed to be a shaded jar but it is now inadvertently dragging in the org.checkerframework classes unshaded. This is causing build issues with projects consuming presto-jdbc since they now see duplicate classes for org.checkerframework -- one coming from guava and another from this unshaded presto-jdbc.

Impact

Projects using presto-jdbc should now build

Test Plan

At Meta, we have an internal service that uses presto-jdbc and that builds now.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So presto-jdbc is bundling org.checkerframework classes into its own jar? That's unusual. Why does it do that?

@agrawaldevesh
Copy link
Contributor Author

Thanks for reviewing. Please merge it in.

@abhiseksaikia abhiseksaikia merged commit cf79ae9 into prestodb:master Jul 26, 2024
@agrawaldevesh agrawaldevesh deleted the fix_23127 branch July 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants