[native] Handle scan filter with NaN limits during plan conversion#23289
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Jul 24, 2024
Merged
[native] Handle scan filter with NaN limits during plan conversion#23289amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta merged 1 commit intoprestodb:masterfrom
Conversation
The filter implementation in Velox, which is utilized as a pushed-down filter for the scan operator, does not accommodate NaN values as limits. This update ensures that during the Presto to Velox plan conversion, such filters are accurately transformed into their Velox equivalents.
Yuhta
approved these changes
Jul 24, 2024
amitkdutta
approved these changes
Jul 24, 2024
Contributor
amitkdutta
left a comment
amitkdutta
left a comment
There was a problem hiding this comment.
Thanks @bikramSingh91
Contributor
Author
aditi-pandit
approved these changes
Jul 24, 2024
Contributor
@bikramSingh91 : Started a re-run of the tests. Would be safer to have these complete once successfully. |
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter implementation in Velox, which is utilized as a
pushed-down filter for the scan operator, does not accommodate NaN
values as limits. This update ensures that during the Presto to
Velox plan conversion, such filters are accurately transformed into
their Velox equivalents.