Skip to content

[native] Fix crash in httpclient when accessing null eventbase #23258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Jul 19, 2024
Merged

[native] Fix crash in httpclient when accessing null eventbase #23258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/http/HttpClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ folly::SemiFuture<std::unique_ptr<HttpResponse>> HttpClient::sendRequest(
sendRequest(std::move(responseHandler));
};

if (delayMs > 0) {
if (delayMs > 0 && eventBase_ != nullptr) {
Copy link
Copy Markdown
Contributor

@tanjialiang tanjialiang Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else condition uses eventBase_ as well. We should make sure life time of event base be equal or longer than client.

Copy link
Copy Markdown
Contributor Author

@amitkdutta amitkdutta Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are spot on! Let me fix it.

// schedule() is expected to be run in the event base thread
eventBase_->runInEventBaseThread([=]() {
eventBase_->schedule(sendCb, std::chrono::milliseconds(delayMs));
Expand Down