Fix Resource Group State Info#23178
Merged
swapsmagic merged 1 commit intoprestodb:masterfrom Jul 11, 2024
Merged
Conversation
swapsmagic
requested review from
a team,
feilong-liu and
jaystarshot
as code owners
jainxrohit
previously approved these changes
Jul 11, 2024
swapsmagic
force-pushed
the
fix_resource_group_state_info_memoization
branch
from
33333bc to
e31728b
Compare
jainxrohit
approved these changes
Jul 11, 2024
swapsmagic
force-pushed
the
fix_resource_group_state_info_memoization
branch
from
e31728b to
1066006
Compare
NikhilCollooru
approved these changes
Jul 11, 2024
Contributor
|
Nit: suggest adding PR number to the release note entry. |
As part of the memoization introduction, previous PR prestodb#22764 introduced an issue where the endpoint returns the same value all the time when caching is disabled. Fixing it with this change and introducing unit tests to cover both caching enabled and not enabled scenario to verify the result.
swapsmagic
force-pushed
the
fix_resource_group_state_info_memoization
branch
from
1066006 to
b9e2f83
Compare
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of the memoization introduction, previous PR #22764 introduced an issue where the endpoint returns the same value all the time when caching is disabled.
Motivation and Context
Fixing the issue with this change and introducing unit tests to cover both caching enabled and not enabled scenario to verify the result.
Impact
/v1/resourceGroupStateInfo to return correct value when caching is disabled.
Test Plan
unit test
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.