Skip to content

Decouple from HiveErrorCode.HIVE_TOO_MANY_OPEN_PARTITIONS#23168

Merged
elharo merged 1 commit intomasterfrom
decouple
Jul 10, 2024
Merged

Decouple from HiveErrorCode.HIVE_TOO_MANY_OPEN_PARTITIONS#23168
elharo merged 1 commit intomasterfrom
decouple

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Jul 10, 2024

Part of #23165

@elharo elharo force-pushed the decouple branch 2 times, most recently from 97d598e to 05132d1 Compare July 10, 2024 14:09
@elharo elharo marked this pull request as ready for review July 10, 2024 14:09
@elharo elharo requested a review from a team as a code owner July 10, 2024 14:09
@elharo elharo requested a review from presto-oss July 10, 2024 14:09
amitkdutta
amitkdutta previously approved these changes Jul 10, 2024
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @elharo

abhiseksaikia
abhiseksaikia previously approved these changes Jul 10, 2024
Copy link
Contributor

@abhiseksaikia abhiseksaikia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I guess a long term change could be to provide an option to register additional FailureResolvers which are connector specific and remove the dependency on presto-hive-* from presto-verifier.

Please fix the checkstyle violation

@elharo elharo dismissed stale reviews from abhiseksaikia and amitkdutta via ed7405c July 10, 2024 18:14
@elharo elharo force-pushed the decouple branch 2 times, most recently from ed7405c to 4d3b36a Compare July 10, 2024 19:50
@elharo elharo merged commit 8babf0a into master Jul 10, 2024
@elharo elharo deleted the decouple branch July 10, 2024 23:51
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants