Skip to content

[docs] Fix doc build error in release-0.288.rst#23153

Closed
steveburnett wants to merge 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-doc-build-error-4
Closed

[docs] Fix doc build error in release-0.288.rst#23153
steveburnett wants to merge 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-doc-build-error-4

Conversation

@steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Jul 9, 2024

Description

Fixes doc build error

/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/release/release-0.288.rst:39: WARNING: Inline literal start-string without end-string.

I thought that I had caught this in #23079 but apparently not.

Motivation and Context

Builds on work in #23090, #23033, #22876, and #22985.

Like the doc build errors I fixed in the other PRs, these errors don't stop the build but they're annoying, and these are easy and low-risk fixes.

Impact

Documentation builds.

Test Plan

Local doc builds:

before:
build succeeded, 20 warnings.

after:
build succeeded, 19 warnings.

Reviewed local doc build to confirm the fix didn't break any text display or formatting errors.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett self-assigned this Jul 9, 2024
@steveburnett steveburnett requested a review from a team as a code owner July 9, 2024 16:49
@steveburnett steveburnett requested a review from presto-oss July 9, 2024 16:49
@github-actions github-actions bot added the docs label Jul 9, 2024
@steveburnett
Copy link
Contributor Author

ci/circleci: linux-presto-e2e-tests failed, see Details.

elharo
elharo previously approved these changes Jul 9, 2024
tdcmeehan
tdcmeehan previously approved these changes Jul 10, 2024
@steveburnett steveburnett dismissed stale reviews from tdcmeehan and elharo via 41a8582 July 10, 2024 15:19
@steveburnett steveburnett force-pushed the steveburnett-doc-build-error-4 branch from 1644262 to 41a8582 Compare July 10, 2024 15:19
@steveburnett
Copy link
Contributor Author

Added a space after a sentence to re-run the tests, and ci/circleci: linux-presto-e2e-tests failed again.

Today's ci/circleci: linux-presto-e2e-tests failure details

Yesterday's ci/circleci: linux-presto-e2e-tests failure details

Any suggestions?

@steveburnett steveburnett force-pushed the steveburnett-doc-build-error-4 branch from 41a8582 to 4dfb978 Compare July 10, 2024 20:16
@steveburnett steveburnett force-pushed the steveburnett-doc-build-error-4 branch from 4dfb978 to caf7b1a Compare July 11, 2024 16:25
@steveburnett
Copy link
Contributor Author

Closing and resubmitting as #23210 because of test failure mentioned previously.

@steveburnett steveburnett deleted the steveburnett-doc-build-error-4 branch July 15, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants