Introduce a new CoordinatorPlugin interface for native clusters#23144
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Aug 5, 2024
Merged
Introduce a new CoordinatorPlugin interface for native clusters#23144tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
pdabre12
force-pushed
the
plugin-V2
branch
2 times, most recently
from
aee0740 to
8fb4ba4
Compare
pdabre12
changed the title
tdcmeehan
requested changes
Jul 26, 2024
pdabre12
force-pushed
the
plugin-V2
branch
2 times, most recently
from
72ec801 to
0159601
Compare
pdabre12
requested review from
a team,
elharo,
feilong-liu,
jaystarshot and
vivek-bharathan
as code owners
pdabre12
changed the title
elharo
reviewed
Jul 29, 2024
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Show resolved
Hide resolved
tdcmeehan
previously approved these changes
Jul 31, 2024
tdcmeehan
reviewed
Jul 31, 2024
pdabre12
force-pushed
the
plugin-V2
branch
2 times, most recently
from
008ff16 to
21f8042
Compare
tdcmeehan
requested changes
Aug 1, 2024
Contributor
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
One tiny nit, otherwise LGTM
presto-spi/src/main/java/com/facebook/presto/spi/CoordinatorPlugin.java
Outdated
Show resolved
Hide resolved
tdcmeehan
approved these changes
Aug 1, 2024
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new CoordinatorPlugin interface for native clusters.
Test Plan
Unit tests
Resolves : #23297