Skip to content

Upgrade json-path to 2.9.0 due CVE-2023-1370#23104

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
denodo-research-labs:cve_2023_1370_json_smart
Jul 24, 2024
Merged

Upgrade json-path to 2.9.0 due CVE-2023-1370#23104
tdcmeehan merged 1 commit intoprestodb:masterfrom
denodo-research-labs:cve_2023_1370_json_smart

Conversation

@denodo-research-labs
Copy link
Contributor

@denodo-research-labs denodo-research-labs commented Jul 1, 2024

Upgrade json-path to 2.9.0 due CVE-2023-1370.
CVE-2023-1370 is in the transitive dependency json-smart 2.4.7.

Motivation and Context

Solve CVE of severity HIGH.

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Upgrade json-path to 2.9.0 due CVE-2023-1370 :pr:`23104`

CVE-2023-1370 is in the transitive-dependency json-smart 2.4.7
@denodo-research-labs denodo-research-labs requested a review from a team as a code owner July 1, 2024 08:17
@elharo
Copy link
Contributor

elharo commented Jul 1, 2024

Why/where do we use json-smart? It looks unmaintained and risky. Can we just remove/replace it?

@elharo
Copy link
Contributor

elharo commented Jul 1, 2024

Looks like we should be able to remove this dependency completely. Less dependencies --> less security bugs

@denodo-research-labs
Copy link
Contributor Author

Why/where do we use json-smart? It looks unmaintained and risky. Can we just remove/replace it?

Code changes are needed, because without explicitly setting the mapping provider the default JsonSmartMappingProvider is used.

Testing should be done with other available mapping providers such as JacksonMappingProvider, GsonMappingProvider, or JakartaJsonProvider.

@tdcmeehan tdcmeehan self-assigned this Jul 24, 2024
@tdcmeehan
Copy link
Contributor

Thank you @denodo-research-labs

@tdcmeehan tdcmeehan merged commit dd86e0c into prestodb:master Jul 24, 2024
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants