Treat Low Confidence, 0 estimations as unknown during joins#23047
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Jul 16, 2024
abhinavmuk04:milestone2p2
Merged
Treat Low Confidence, 0 estimations as unknown during joins#23047feilong-liu merged 1 commit intoprestodb:masterfrom abhinavmuk04:milestone2p2
feilong-liu merged 1 commit intoprestodb:masterfrom
abhinavmuk04:milestone2p2
Conversation
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jul 8, 2024
Contributor
feilong-liu
left a comment
There was a problem hiding this comment.
Also we need to have a session property to guard this feature.
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Show resolved
Hide resolved
Contributor
|
I think a word ("joins") is missing from the release note entry. Suggested edit: |
feilong-liu
reviewed
Jul 13, 2024
...src/main/java/com/facebook/presto/sql/planner/iterative/LowConfidenceZeroEstimationUtil.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jul 15, 2024
...in/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcastUtil.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcastUtil.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
feilong-liu
approved these changes
Jul 16, 2024
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Treat Low Confidence, 0 estimations as unknown during joins
Motivation and Context
When a node has a low confidence and a 0 estimation it is likely due to the fact that there has been multiple filters pushed down on it. Additionally, sometimes this estimation can actually be so incorrect that it can have us broadcasting the wrong side entirely leading to a failed query. This will help us avoid this.
Impact
This can result in faster query execution times and improved overall performance.
Test Plan
Create plans tests where there are example of low confidence 0 estimation statistics and ensure behavior is as expected from the change. For more specific details on test plan please visit here
Contributor checklist
Release Notes