Skip to content

Update Joda-Time to 2.12.7#23027

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:joda1
Jun 19, 2024
Merged

Update Joda-Time to 2.12.7#23027
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:joda1

Conversation

@amitkdutta
Copy link
Contributor

@amitkdutta amitkdutta commented Jun 18, 2024

Description

Update Joda-Time from from 2.12.5 to 2.12.7. The tzdata version is upgraded from 2023c to 2024a and the changes are:

Motivation and Context

fix #22981

Impact

Fixes existing bug discussed in #22981

Test Plan

Wrote an unit test in previous commit that shows correct result for the issue discussed in #22981. Can't commit here because the CI system jvm needs to be updated with the new tzdata.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Update Joda-Time to 2.12.7 to use 2024a tzdata. 
  Note: a corresponding update to the Java runtime should also be made to ensure consistent timezone data.
  For example, Oracle JDK 8u381, tzdata2024a rpm for OpenJDK, or use Timezone Updater Tool to apply
  2024a tzdata to existing JVM. :pr:`23027`

@amitkdutta amitkdutta requested a review from a team as a code owner June 18, 2024 06:21
@amitkdutta amitkdutta requested a review from presto-oss June 18, 2024 06:21
@amitkdutta amitkdutta marked this pull request as draft June 18, 2024 06:21
@amitkdutta amitkdutta marked this pull request as ready for review June 18, 2024 17:12
yhwang
yhwang previously approved these changes Jun 18, 2024
Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM

@steveburnett
Copy link
Contributor

Suggest minor edit to release note entry to add the PR #.

== RELEASE NOTES ==

General Changes
* Update Joda-Time to2.12.7 to use 2024a tzdata. 
  Note: a corresponding update to the Java runtime should also be made to ensure consistent timezone data.
  For example, Oracle JDK 8u381, tzdata2024a rpm for OpenJDK, or use Timezone Updater Tool to apply
  2024a tzdata to existing JVM. :pr:`23027`

@amitkdutta
Copy link
Contributor Author

Suggest minor edit to release note entry to add the PR #.

== RELEASE NOTES ==

General Changes
* Update Joda-Time to2.12.7 to use 2024a tzdata. 
  Note: a corresponding update to the Java runtime should also be made to ensure consistent timezone data.
  For example, Oracle JDK 8u381, tzdata2024a rpm for OpenJDK, or use Timezone Updater Tool to apply
  2024a tzdata to existing JVM. :pr:`23027`

Thanks @steveburnett. Updated as you suggested.

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amitkdutta

@amitkdutta amitkdutta merged commit 6110456 into prestodb:master Jun 19, 2024
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong timezone conversions for "America/Scoresbysund"

5 participants