Prioritize high confidence stats during broadcast joins#23016
Merged
abhinavmuk04 merged 1 commit intoprestodb:masterfrom Jul 1, 2024
abhinavmuk04:milestone2p1
Merged
Prioritize high confidence stats during broadcast joins#23016abhinavmuk04 merged 1 commit intoprestodb:masterfrom abhinavmuk04:milestone2p1
abhinavmuk04 merged 1 commit intoprestodb:masterfrom
abhinavmuk04:milestone2p1
Conversation
rschlussel
reviewed
Jun 25, 2024
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Jun 25, 2024
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jun 28, 2024
presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
...t/java/com/facebook/presto/sql/planner/iterative/rule/TestDetermineJoinDistributionType.java
Show resolved
Hide resolved
presto-tests/src/test/java/com/facebook/presto/execution/TestHistoryBasedStatsTracking.java
Show resolved
Hide resolved
feilong-liu
reviewed
Jun 29, 2024
...o-main/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcast.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jul 1, 2024
...in/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcastUtil.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jul 1, 2024
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
feilong-liu
approved these changes
Jul 1, 2024
Contributor
|
Code lgtm. However, as a code owner, I do not have ownership for the SystemSessionProperty file, will need an committer approval for help to merge the change here. |
NikhilCollooru
approved these changes
Jul 1, 2024
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prioritize high confidence stats during broadcast joins if enabled
Motivation and Context
When there are two PlanNodes in which they are both small enough for broadcast join we will prioritize the side which has higher confidence stats. If they both have high confidence stats then we keep the original behavior. The user has the ability to turn this on and off.
Impact
This change will create a feature which the user can utilize to improve optimization and help improve the execution time of broadcast join queries
Test Plan
Implemented various tests in both DetermineJoinDistributionType and ReorderJoinsType, which will check if, with the session property enable, nodes with the higher confidence stats will be broadcasted
Contributor checklist
Release Notes