Skip to content

[Verifier] Wrap checksum queries with partition predicate for reused output table#22965

Merged
gggrace14 merged 1 commit intoprestodb:masterfrom
gggrace14:scaledverifierpartition
Jul 19, 2024
Merged

[Verifier] Wrap checksum queries with partition predicate for reused output table#22965
gggrace14 merged 1 commit intoprestodb:masterfrom
gggrace14:scaledverifierpartition

Conversation

@gggrace14
Copy link
Contributor

For Insert and CTAS queries, when output table reuse is on, build the partition
predicate and apply it when assembling the checksum queries.

== RELEASE NOTES ==

Verifier Changes
* Add `control.reuse-table` and `test.reuse-table` configuration properties for the Presto Verifier to reuse the output tables of the source query for control and test.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Nit for formatting, looks good otherwise.

@gggrace14 gggrace14 force-pushed the scaledverifierpartition branch 4 times, most recently from b002bad to 2c8c7e3 Compare June 13, 2024 18:32
@gggrace14 gggrace14 requested a review from steveburnett June 13, 2024 18:33
arhimondr
arhimondr previously approved these changes Jun 13, 2024
steveburnett
steveburnett previously approved these changes Jun 13, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new doc build, looks good. Thanks!

…output table

For Insert and CTAS queries, when output table reuse is on, build the partition
predicate and apply it when assembling the checksum queries.
@gggrace14 gggrace14 dismissed stale reviews from steveburnett and arhimondr via 3c1b507 July 19, 2024 02:22
@gggrace14 gggrace14 force-pushed the scaledverifierpartition branch from 2c8c7e3 to 3c1b507 Compare July 19, 2024 02:22
@gggrace14 gggrace14 requested a review from feilong-liu July 19, 2024 03:42
Copy link
Contributor

@feilong-liu feilong-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gggrace14 gggrace14 merged commit 632eb58 into prestodb:master Jul 19, 2024
@gggrace14 gggrace14 deleted the scaledverifierpartition branch July 19, 2024 03:46
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants